From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70486 invoked by alias); 14 Jul 2017 16:50:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70470 invoked by uid 89); 14 Jul 2017 16:50:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:786 X-HELO: gproxy7.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 16:50:02 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id B194A215D8E for ; Fri, 14 Jul 2017 10:50:00 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id kgpx1v00i2f2jeq01gq0Zi; Fri, 14 Jul 2017 10:50:00 -0600 X-Authority-Analysis: v=2.2 cv=FvB1xyjq c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=20KFwNOVAAAA:8 a=sf15p09uSMfMyO-l1LIA:9 Received: from 174-29-39-24.hlrn.qwest.net ([174.29.39.24]:49588 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dW3mv-001UM8-Ak; Fri, 14 Jul 2017 10:49:57 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Fix two regressions in scalar printing References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-2-tom@tromey.com> <22c48f9e-ec2c-850d-91d3-c6a3ea8cdb11@redhat.com> Date: Fri, 14 Jul 2017 16:50:00 -0000 In-Reply-To: <22c48f9e-ec2c-850d-91d3-c6a3ea8cdb11@redhat.com> (Pedro Alves's message of "Fri, 14 Jul 2017 15:56:27 +0100") Message-ID: <871spjufnv.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dW3mv-001UM8-Ak X-Source-Sender: 174-29-39-24.hlrn.qwest.net (pokyo) [174.29.39.24]:49588 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-07/txt/msg00192.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I think this would all be fixed by simply having separate Pedro> 'u'/'d' cases with fixed signness: Pedro> case 'u': Pedro> print_decimal_chars (stream, valaddr, len, false, byte_order); Pedro> break; Pedro> case 'd': Pedro> print_decimal_chars (stream, valaddr, len, true, byte_order); Pedro> break; I'm testing this. Thanks for the feedback. One early note is that this changes the expected output for this test: FAIL: gdb.dwarf2/var-access.exp: verify re-initialized s2 Now it says: print/d s2 $9 = {a = -65, b = 73, c = -25, d = 123} but the test wants: gdb_test "print/d s2" " = \\{a = 191, b = 73, c = 231, d = 123\\}" \ "verify re-initialized s2" Tom