From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118577 invoked by alias); 23 Aug 2017 13:19:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118549 invoked by uid 89); 23 Aug 2017 13:19:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 13:19:02 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BEBA44ACA7; Wed, 23 Aug 2017 13:19:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BEBA44ACA7 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76EA967C9C; Wed, 23 Aug 2017 13:19:00 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , GCC Patches , Tom Tromey , Keith Seitz , Phil Muldoon , Alexandre Oliva Subject: Re: [libcc1] Improve detection of triplet on compiler names References: <87mv6qhq9u.fsf@redhat.com> <74900a91-685b-2bdc-6cb7-8333ce9c5d0a@redhat.com> <87a82qh1pn.fsf@redhat.com> Date: Wed, 23 Aug 2017 13:19:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 23 Aug 2017 14:14:52 +0100") Message-ID: <871so2h16k.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00442.txt.bz2 On Wednesday, August 23 2017, Pedro Alves wrote: > On 08/23/2017 02:07 PM, Sergio Durigan Junior wrote: >> On Wednesday, August 23 2017, Pedro Alves wrote: >> >>> On 08/23/2017 05:17 AM, Sergio Durigan Junior wrote: >>>> The GCC patch improves the libcc1::compiler_triplet_regexp::find and >>>> libcp1::compiler_triplet_regexp::find methods by first trying to match >>>> the triplet in the compiler name and correctly discarding the triplet >>>> part of the regexp if the matching succeeds. I've had to do a few >>>> modifications on the way the regexp's are built, but I'll explain them >>>> in the patch itself. >>>> >>>> The GDB patch is very simple: it adds the trailing "-" in the triplet >>>> regexp. Therefore, we will have a regexp that truly matches the full >>>> triplet (e.g., "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?-") instead of one >>>> that leaves the trailing "-" match to libcc1. >>>> >>>> I've tested this patch both on my Fedora and my Debian machines, and >>>> both now work as expected, independently of the presence of the triplet >>>> string in the compiler name. I am sorry about the cross-post, but these >>>> patches are really dependent on one another. >>> >>> Is there a backward/forward compatibility impact? >> >> Unfortunately, yes. >> >>> Does new GDB work with old GCC? >> >> No. On Fedora systems, you would get: >> >> Could not find a compiler matching "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?--gcc$" >> > > That's a problem then. Please read this: > > https://sourceware.org/gdb/wiki/GCCCompileAndExecute#How_to_extend_the_gdb.2BAC8-gcc_interface OK, thanks, I'll follow the advices from the wiki. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/