From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28937 invoked by alias); 21 Nov 2017 16:25:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28923 invoked by uid 89); 21 Nov 2017 16:25:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=living, act X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 16:25:18 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B990F821C7; Tue, 21 Nov 2017 16:25:17 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B41661F32; Tue, 21 Nov 2017 16:25:17 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Simon Marchi Subject: Re: [PATCH v2 0/3] Convert probe interfaces to C++ (and perform some cleanups) References: <20171113175901.25367-1-sergiodj@redhat.com> <20171116043734.10137-1-sergiodj@redhat.com> Date: Tue, 21 Nov 2017 16:25:00 -0000 In-Reply-To: <20171116043734.10137-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 15 Nov 2017 23:37:31 -0500") Message-ID: <871skroaz7.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00442.txt.bz2 Ping. On Wednesday, November 15 2017, I wrote: > [ The changes for each patch are described at the top of each message. ] > > This patch series performs the conversion of the probe interfaces > (generic, stap and dtrace) to C++, along with a few cleanups here and > there to make the code conform better to our standards. > > This series needs to be committed/tested as one single patch, because > of inter-dependencies. However, in order to facilitate the review > process, I decided to split things into logical units. > > The main changes are the conversion of 'struct probe' to 'class > probe', and 'struct probe_ops' to 'class static_probe_ops'. Almost > everything else in the patches are adjustments related to these > modifications. > > It's important to say that 'class probe' contains the majority of the > methods that were previously living inside 'struct probe_ops'. > However, some methods are special in the sense the they don't act on a > specific probe object, but generically on a probe type (like a > factory). For that reason the 'class static_probe_ops' had to be > created. > > Most methods in 'class probe' are pure virtual and need to be defined > by the probe backend (stap or dtrace, for now). Other methods (e.g., > the 'enable' method) are virtual but non-pure and have a default, > dummy version implemented on 'class probe' itself, because the concept > of enabling a probe is not common to all types of probes. > > I've also taken the opportunity to convert a few uses of "VEC" to > "std::vector", and to remove annoying spurious newlines from some > places. > > The whole patch has been tested on BuildBot, without regressions. > However, it is important to mention that I could not test the DTrace > part of the patch because the test framework used to test it is not > working; see . -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/