From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18095 invoked by alias); 4 Jun 2018 18:11:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18084 invoked by uid 89); 4 Jun 2018 18:11:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.123) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 18:11:35 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 7C2CA8CEB4 for ; Mon, 4 Jun 2018 13:11:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ptx8fsArLPvAdPtx8f5PGv; Mon, 04 Jun 2018 13:11:34 -0500 X-Authority-Reason: nr=8 Received: from 75-166-34-65.hlrn.qwest.net ([75.166.34.65]:37604 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fPtx7-003FgJ-QD; Mon, 04 Jun 2018 13:11:34 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/6] Change representation of psymbol to flush out accessors References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-3-tom@tromey.com> <15d0da9f-93fa-5d23-ce4e-43d5befe48e7@redhat.com> Date: Mon, 04 Jun 2018 18:11:00 -0000 In-Reply-To: <15d0da9f-93fa-5d23-ce4e-43d5befe48e7@redhat.com> (Keith Seitz's message of "Fri, 1 Jun 2018 12:19:29 -0700") Message-ID: <871sdm5smj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fPtx7-003FgJ-QD X-Source-Sender: 75-166-34-65.hlrn.qwest.net (bapiya) [75.166.34.65]:37604 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00074.txt.bz2 >>>>> "Keith" == Keith Seitz writes: >> + h = hash_continue (&psymbol->pginfo.name, sizeof (psymbol->pginfo.name), h); Keith> I realize this is just a renaming of the existing code, but since Keith> there is an accessor for `name', I think it better to use it (in Keith> case someone ends up grepping for this). [...] Keith> Same here for PSYMBOL_LANGUAGE and PSYMBOL_LINKAGE_NAME? I've made these changes locally. Tom