From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58699 invoked by alias); 15 Jul 2018 17:55:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58686 invoked by uid 89); 15 Jul 2018 17:55:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:780, resending X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Jul 2018 17:55:03 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway34.websitewelcome.com (Postfix) with ESMTP id B8C4C39667 for ; Sun, 15 Jul 2018 12:55:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id elEbfDA5X79N3elEbfZz1F; Sun, 15 Jul 2018 12:55:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EGgSqEr3iRaB6JbA+v0Zzf+29U6t/OeuajYwKOp4cwU=; b=Ak5qeFI1i4VUKLtMBqeBNvfh5o XIEowhnvvdx8YPDY9mwQMnk91//MNGDe8i5kwzoEfHEExuly+GArkIsah8IyAgEmmfe4CagQU09EZ 5TdAZRFHoiu74XwX/SANv3m6R; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:36076 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1felEb-000bC3-EZ; Sun, 15 Jul 2018 12:55:01 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 28/42] Set list_in_scope later in DWARF reader References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-29-tom@tromey.com> Date: Sun, 15 Jul 2018 17:55:00 -0000 In-Reply-To: (Keith Seitz's message of "Fri, 6 Jul 2018 11:11:39 -0700") Message-ID: <871sc49yff.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00466.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> On 05/22/2018 09:58 PM, Tom Tromey wrote: >> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >> index 3cc15ab645..f7cca01445 100644 >> --- a/gdb/dwarf2read.c >> +++ b/gdb/dwarf2read.c >> @@ -21138,6 +21134,8 @@ dwarf2_start_symtab (struct dwarf2_cu *cu, >> = start_symtab (cu->per_cu->dwarf2_per_objfile->objfile, name, comp_dir, >> low_pc, cu->language); >> >> + cu->list_in_scope = get_file_symbols (); >> + >> record_debugformat ("DWARF 2"); >> record_producer (cu->producer); >> >> Keith> Warning: `get_file_symbols' is undefined until the next patch. Thanks. I've fixed this. I'll make sure to build each patch in the series before re-sending. Tom