From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93675 invoked by alias); 8 Aug 2018 17:30:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93574 invoked by uid 89); 8 Aug 2018 17:30:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1508 X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 17:30:00 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway32.websitewelcome.com (Postfix) with ESMTP id BD7361AC2C2 for ; Wed, 8 Aug 2018 12:29:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nSH1f90LcbXuJnSHJfXugk; Wed, 08 Aug 2018 12:29:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TkE4LyBGV6ohxrHe6b3X1CfXx6qiW0XctGJIm5tOqbE=; b=GWeRzbvDZ5oPGSY5xw1uhE1Bnn Q6/wYua6ZuFUinreKZayFb+pIjX8eOfseemeuJ48DKHbk83LTeTt3tm/VzAPCuUhlQVnouPHnq3+h gUxcCUFZGe7T0JY6svVPsspou; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:56618 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnSH1-000Zjo-4v; Wed, 08 Aug 2018 12:29:27 -0500 From: Tom Tromey To: Jim Wilson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] RISC-V: Add configure support riscv*-linux*. References: <20180808021734.7844-1-jimw@sifive.com> Date: Wed, 08 Aug 2018 17:30:00 -0000 In-Reply-To: <20180808021734.7844-1-jimw@sifive.com> (Jim Wilson's message of "Tue, 7 Aug 2018 19:17:34 -0700") Message-ID: <871sb8ahs9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00167.txt.bz2 >>>>> "Jim" == Jim Wilson writes: Jim> * Makefile.in (ALLDEPFILES): Add riscv-linux-nat.c, riscv-linux-tdep.c. This doesn't mention the ALL_TARGET_OBS change. Jim> * NEWS: Mention new GNU/Linux RISC-V target. Eli should review this bit. Jim> * configure.host: Add riscv*-*-linux*. Jim> * configure.nat: Add riscv*. Jim> * configure.tgt: Add riscv*-*-linux*. These parts are ok. Jim> diff --git a/gdb/Makefile.in b/gdb/Makefile.in Jim> index 8c744d70c0..280b3b1283 100644 Jim> --- a/gdb/Makefile.in Jim> +++ b/gdb/Makefile.in Jim> @@ -752,6 +752,8 @@ ALL_TARGET_OBS = \ Jim> ppc-sysv-tdep.o \ Jim> ppc64-tdep.o \ Jim> ravenscar-thread.o \ Jim> + riscv-linux-nat.o \ Jim> + riscv-linux-tdep.o \ Jim> riscv-tdep.o \ Jim> rl78-tdep.o \ Jim> rs6000-aix-tdep.o \ I think only the tdep file should be listed here. ALL_TARGET_OBS is used when --enable-targets=all is given. In this case, we would not want the riscv-linux-nat.o object to be linked in, since we're not necessarily building on linux. Is riscv a 64-bit architecture? (I don't know.) If so, gdb still splits 64-bit targets into a separate variable, I think in case one is building on a 32-bit machine without a 64-bit integer type (or maybe if you didn't want to use the extra memory to inflate a bunch of type sizes, not sure). In this case you'd want to add the tdep file to ALL_64_TARGET_OBS instead. I wonder if this 32/64 bit thing is needed any more. Tom