From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84854 invoked by alias); 21 Aug 2018 18:01:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84780 invoked by uid 89); 21 Aug 2018 18:01:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=philippe, Philippe, hunk, breakpointc X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Aug 2018 18:01:18 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 0BF28BF75 for ; Tue, 21 Aug 2018 13:01:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id sAxMfYB6UbXuJsAxifusld; Tue, 21 Aug 2018 13:01:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XUyjaYoY5+DcWXlTF1GWcVk982lzWgBBsWCUPlHHMlw=; b=qamb2l0BwSgdas74L9ZroiNXUF RnxK6xuOotrH7dyhhuYfQ85CZkxsJrZLChxAyBLFOkw1CwKkcenjwRUxiJFZfF8AoPcfke/zzrmxF 1Q0IH3k21c7FrRhg+tqRk/VVm; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:49728 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fsAxM-000lCL-IA; Tue, 21 Aug 2018 13:00:40 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing References: <20180802212613.29813-1-philippe.waroquiers@skynet.be> <20180802212613.29813-2-philippe.waroquiers@skynet.be> Date: Tue, 21 Aug 2018 18:01:00 -0000 In-Reply-To: <20180802212613.29813-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Thu, 2 Aug 2018 23:26:12 +0200") Message-ID: <871sarr456.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00504.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> 2018-08-02 Philippe Waroquiers Philippe> * breakpoint.c (commands_command_1): New boolean cmd_read Philippe> to detect cmd was already read. Always allocate a new_arg Philippe> c_str to avoid accessing arg after some calls to Philippe> read_command_line as this can free arg memory. Hi. I have been meaning to update this to account for the fix I recently put in, but I've been very ill and so I haven't been able to. Philippe> + else Philippe> + { Philippe> + new_arg = arg; Philippe> + arg = new_arg.c_str (); Philippe> + } I think it should work ok now if you just remove this hunk. Tom