From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99224 invoked by alias); 31 Aug 2018 15:33:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99214 invoked by uid 89); 31 Aug 2018 15:33:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 15:33:23 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 899724DA83 for ; Fri, 31 Aug 2018 10:33:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vlPnfto5PBcCXvlQ4fNXzM; Fri, 31 Aug 2018 10:33:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NNu8Bc6AWEcpyjoEZt2Ahkp8IvokRnhMCBhiUTcNbiM=; b=XNxYsmr0CxJVlRd7dLYV8FBin9 IwR/uIGIPaxTce5iGtE8i//Z7+kqO0Q8ZV6aeMwDEkHlgSw/4rJC2YsqLvcudKrO/vqabtBgYvim9 Onpp4HHhpr2w9Q+NHi2RwYQQ7; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:58506 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fvlPn-000LF1-4T; Fri, 31 Aug 2018 10:32:51 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint References: <20180831151159.10583-1-palves@redhat.com> <20180831151159.10583-2-palves@redhat.com> Date: Fri, 31 Aug 2018 15:33:00 -0000 In-Reply-To: <20180831151159.10583-2-palves@redhat.com> (Pedro Alves's message of "Fri, 31 Aug 2018 16:11:58 +0100") Message-ID: <871sae1rh9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00869.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> target_have_continuable_watchpoint isn't used anywhere so remove it. Pedro> The property isn't necessary because checking for "continuable" is the Pedro> same as checking for "!steppable && !non-steppable". Pedro> /* If the *_hw_beakpoint functions have not been defined Pedro> diff --git a/gdb/x86-nat.h b/gdb/x86-nat.h Pedro> index cc27fa43b4d..f6d8a26baf9 100644 Pedro> --- a/gdb/x86-nat.h Pedro> +++ b/gdb/x86-nat.h Pedro> @@ -76,8 +76,6 @@ struct x86_nat_target : public BaseTarget Pedro> the one that caused the trap. Therefore we don't need to step Pedro> over it. But we do need to reset the status register to avoid Pedro> another trap. */ Pedro> - bool have_continuable_watchpoint () override Pedro> - { return true; } I think the comment just before this function should also be removed. Tom