From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76294 invoked by alias); 11 Sep 2018 15:41:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76280 invoked by uid 89); 11 Sep 2018 15:41:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1083 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.64.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 15:41:18 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id D8874400F5CC8 for ; Tue, 11 Sep 2018 10:41:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id zkmgfawwgRPojzkmrfyZpl; Tue, 11 Sep 2018 10:41:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mdsm4H1LEPjv74VkleV6a4vWZXa0c/jLnuqQTKvwo84=; b=kZWfeQ0MH3E096PDAfx2oC2s1/ jGEE/Xbi+jAP9eTaSXViHqpmvRA9o1pzd+cdUYYWcp5NokWSV5HZdhBjpSjf0KajpmQi/nhQtcRuc TOr1e0aegcSc5qSdXWkdDL6ck; Received: from 97-122-189-157.hlrn.qwest.net ([97.122.189.157]:58508 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fzkmg-003zur-CC; Tue, 11 Sep 2018 10:40:58 -0500 From: Tom Tromey To: Joel Brobecker Cc: Simon Marchi , gdb-patches@sourceware.org, Jerome Guitton Subject: Re: [RFA v2] arm-pikeos: software single step References: <20180910174345.GD3234@adacore.com> <20180911085612.GA3379@adacore.com> Date: Tue, 11 Sep 2018 15:41:00 -0000 In-Reply-To: <20180911085612.GA3379@adacore.com> (Joel Brobecker's message of "Tue, 11 Sep 2018 10:56:12 +0200") Message-ID: <871sa0rqie.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00339.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> + long max_number_of_symbols Joel> + = bfd_get_symtab_upper_bound (abfd) / sizeof (asymbol *); Joel> + if (max_number_of_symbols <= 0) Joel> + return GDB_OSABI_UNKNOWN; Joel> + std::vector symbol_table (max_number_of_symbols); Joel> + number_of_symbols = bfd_canonicalize_symtab (abfd, symbol_table.data ()); Joel> + if (number_of_symbols <= 0) Joel> + return GDB_OSABI_UNKNOWN; Joel> + gdb_assert (number_of_symbols <= max_number_of_symbols); Joel> + symbol_table.resize (number_of_symbols); I looked, and some spots doing this just use xmalloc and manage it manually. machoread though uses gdb::def_vector; which is nice since it doesn't clear the memory. Joel> + for (i = 0; i < number_of_symbols; i++) If you have an explicit bound on the loop then you don't need to resize the vector to be smaller. No idea why it isn't working for you, the patch looks ok to me. Sorry about this. If you'd rather get it in, I can remove the cleanup later. Tom