From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search)
Date: Fri, 30 Nov 2018 20:42:00 -0000 [thread overview]
Message-ID: <871s72mh5i.fsf@tromey.com> (raw)
In-Reply-To: <6e8a2a00-bcbd-cdc6-f332-f59988bb8c40@redhat.com> (Pedro Alves's message of "Fri, 30 Nov 2018 19:43:36 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> -/* FIXME!!! We walk right off the end of buf if we get a long line!!! */
I'm surprised all those exclamation marks didn't help us find this
sooner. /s
Pedro> I don't think there's much point in reusing the buffer across
Pedro> command invocations.
Agreed.
Pedro> - msg = (char *) re_comp (regex);
Pedro> + char *msg = (char *) re_comp (regex);
Pre-existing, but I wonder why this cast is needed. I think "const char
*msg" and removing the cast ought to be completely fine. Or (more work)
avoid re_comp and use compiled_regex instead.
The rest seems fine to me. Thank you for doing this.
Tom
next prev parent reply other threads:[~2018-11-30 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 23:34 [RFA] Fix leak in forward-search Philippe Waroquiers
[not found] ` <3cf960b8-ff82-0670-fa90-c94d78573bfe@redhat.com>
2018-11-29 23:05 ` Philippe Waroquiers
2018-11-30 19:43 ` [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search) Pedro Alves
2018-11-30 20:42 ` Tom Tromey [this message]
2018-12-08 15:12 ` Pedro Alves
2018-12-02 16:57 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s72mh5i.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox