From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122630 invoked by alias); 29 Dec 2018 19:33:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122600 invoked by uid 89); 29 Dec 2018 19:33:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:494 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 29 Dec 2018 19:33:17 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 67CDB49E02 for ; Sat, 29 Dec 2018 13:33:16 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dKMGg7A2NYTGMdKMGguZKD; Sat, 29 Dec 2018 13:33:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2SbVaDgzyO3/EJOY54c1vdP79YwJSIrOpcCq89J5PpY=; b=WSS60/TgQyPLr6CF8t9z1qv7mw SDSDMCpfxtZJxb4qu8rgZRa5eFe2mlUDN/hJiU2G9wCb17jMPmcHEo/aevEnAWkV4PrlBPJ8kYDbI 2uiDPZ5tMvpxl/b1dewQu5/s2; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:36648 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gdKMG-001rZe-5T; Sat, 29 Dec 2018 13:33:16 -0600 From: Tom Tromey To: Tom Tromey Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [RFA] Fix leak in most gdb.mi tests. References: <20181229170116.8588-1-philippe.waroquiers@skynet.be> <87a7kom9ez.fsf@tromey.com> Date: Sat, 29 Dec 2018 19:33:00 -0000 In-Reply-To: <87a7kom9ez.fsf@tromey.com> (Tom Tromey's message of "Sat, 29 Dec 2018 12:15:32 -0700") Message-ID: <871s60m8lg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00420.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This all seems somewhat ugly to me. Perhaps ideally the caller should Tom> manage the memory and input_handler should take a const char *? But not Tom> your problem, fixing the leak is enough. I poked at this and it isn't trivial due to gdb_readline_wrapper_line. Maybe input_handler could accept a unique_xmalloc_ptr&& instead. That would at least clarify the ownership semantics. Tom