From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89694 invoked by alias); 5 Mar 2019 22:24:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89610 invoked by uid 89); 5 Mar 2019 22:24:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=2.1 required=5.0 tests=BAYES_00,BODY_8BITS,GARBLED_BODY,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy==d0=be=d0=b2, 2017-02, 201702?= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Mar 2019 22:23:58 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 1C89971628 for ; Tue, 5 Mar 2019 16:10:10 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1IGIhZvKzdnCe1IGIhV2Ji; Tue, 05 Mar 2019 16:10:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y7Kxw95dBxAxs+F8gBca74tLvpPsTowLG8ZWqnbjiC4=; b=OEW1yWDLCUeRLPOWq+PqushwWN EgkkZ9eWv828/jkwHrJGrfx5pqnSi/8ItdLl2V7oCwJCZNUWhnFa4546y5lWLEcjrDLBJun7BuC3O aPXGfqmbbxOY+ji9ksy1d0R3Z; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:56024 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h1IGH-000pNZ-QJ; Tue, 05 Mar 2019 16:10:09 -0600 From: Tom Tromey To: LRN Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Apply substitute-path to relative filenames as well References: <5a785bba-7432-f6e0-1089-5d2bdd3450a3@gmail.com> Date: Tue, 05 Mar 2019 22:24:00 -0000 In-Reply-To: <5a785bba-7432-f6e0-1089-5d2bdd3450a3@gmail.com> (LRN's message of "Thu, 28 Feb 2019 15:52:15 +0300") Message-ID: <871s3lq8fy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-03/txt/msg00080.txt.bz2 >>>>> "LRN" =3D=3D LRN writes: LRN> The patch is attached. LRN> The change itself is similar to LRN> https://www.sourceware.org/ml/gdb-patches/2017-02/msg00693.html , but = the code LRN> is slightly cleaner (at the cost of making the patch larger). Thank you for the patch. LRN> Also, as the patch is trivial, so i would expect it to not to require = copyright LRN> assignment (i do have one, but David Grayson might not have). I agree. LRN> 2019-02-28 =D0=A0=D1=83=D1=81=D0=BB=D0=B0=D0=BD =D0=98=D0=B6=D0=B1=D1= =83=D0=BB=D0=B0=D1=82=D0=BE=D0=B2 LRN> * source.c (find_and_open_source): Apply substitute-path to all LRN> filenames, both absolute and relative Is it possible to get a test case for the patch? LRN> gdb::unique_xmalloc_ptr rewritten_filename; [...] LRN> + rewritten_filename =3D rewrite_source_path (filename); I think these two lines can now be joined; no need to have a separate assignment. thanks, Tom