From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87045 invoked by alias); 19 Apr 2019 19:03:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87037 invoked by uid 89); 19 Apr 2019 19:03:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Apr 2019 19:03:53 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id EB4075885BE for ; Fri, 19 Apr 2019 14:03:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HYnfhRgghYTGMHYnfhYeC0; Fri, 19 Apr 2019 14:03:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GSvYDTGaJCi6Lo9ccKLrLawNZ0MgHeDjc1e+4cNVSRc=; b=oo2IuOJTkBLmCCbElZJpWenvyJ p6+YTK1WoIEX+vX5AOLbgyHvip8CGAGLkuRVmMRSxyVcfVYmiNPzKT1q70E+hkY76DfkPhLYKGVos PIDtTjzv+kcjUpde3A0YY9Ia9; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:45524 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hHYnf-001oTA-Mw; Fri, 19 Apr 2019 14:03:51 -0500 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix "list" when control characters are seen References: <20190409185432.16985-1-tromey@adacore.com> Date: Fri, 19 Apr 2019 19:03:00 -0000 In-Reply-To: <20190409185432.16985-1-tromey@adacore.com> (Tom Tromey's message of "Tue, 9 Apr 2019 12:54:32 -0600") Message-ID: <871s1xes15.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00383.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> PR symtab/24423 points out that control characters in a source file Tom> cause a hang in the "list" command, a regression introduced by the Tom> styling changes. Tom> This patch, from the PR, fixes the bug. I've included a minimal Tom> change to the "list" test that exercises this code. Tom> I recall that this bug was discussed on gdb-patches, and I thought Tom> there was a patch there as well, but I was unable to find it. I'm going to check this in to master and the 8.3 branch now. Tom