From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52054 invoked by alias); 10 May 2019 19:11:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52045 invoked by uid 89); 10 May 2019 19:11:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=nicely X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.180.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 May 2019 19:11:17 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 1EC5A81DC for ; Fri, 10 May 2019 14:11:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PAvLh8DX22PzOPAvLhZb0j; Fri, 10 May 2019 14:11:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EzRNMYLqjPtiRb3gEukv/0xAC35W4IicuXhLmB3HNW4=; b=WP7mE2I/OsKiJZ8ywmP000VSPd 0Nfev88YArEqYg9rTdh+RfAPYjk+7Q8YjSh4LT1Rj16rlqD3HH9hi2oB1Z5XOTVskNMKTWrRve0BU 0xKpTIxaYmbOE17YXCtBOyozD; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:34000 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hPAvL-003vkc-LK; Fri, 10 May 2019 14:11:15 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org, Tom de Vries Subject: Re: [PATCH] Fix GDB build when using --disable-gdbmi References: <20190510183512.9955-1-simon.marchi@efficios.com> <87a7fu9me8.fsf@tromey.com> <08bf3e6b-11c5-2a90-fb66-d1eced683116@efficios.com> Date: Fri, 10 May 2019 19:11:00 -0000 In-Reply-To: <08bf3e6b-11c5-2a90-fb66-d1eced683116@efficios.com> (Simon Marchi's message of "Fri, 10 May 2019 14:57:36 -0400") Message-ID: <871s169lbh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00262.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> That would require the mi_ui_out object to be created with that flag. However, Simon> this option can be toggled on after the mi_ui_out object has been created (through Simon> the MI command -fix-multi-location-breakpoint-output). Ah, I didn't realize that. Simon> One way to make it work would be, when the -fix-multi-location-breakpoint-output Simon> command is issued, we go through all existing ui_out objects and set that flag. Simon> But I don't think there's an easy way of going through all existing ui_out objects. Simon> If you have any ideas for a more elegant way to make it work, I would be up for it, Simon> because it's true that sprinkling #ifdefs is not the best idea. It's maybe strange that -fix-multi-location-breakpoint-output affects all MI channels and not just the ones associated with the request. It seems like if there are multiple MI channels, then this could confuse some client. But then, making it per-channel would make it not work nicely if a new MI-out is created for a specific command (which I guess is done by mi_load_progress, not sure about things like interpreter-exec). I guess maybe if there's going to be a global, it could just be stuck in breakpoint.c and then flags used for the ui-out version check currently done in mi_multi_location_breakpoint_output_fixed. I'm not really sure this is any better -- globals are bad, but it does avoid the #if. Tom