From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3518 invoked by alias); 13 May 2019 14:01:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3494 invoked by uid 89); 13 May 2019 14:01:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 May 2019 14:01:11 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 884476AA56 for ; Mon, 13 May 2019 09:01:08 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id QBVshtY984FKpQBVshHoO4; Mon, 13 May 2019 09:01:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u1lLO0t+Dv/3U3AY1kV0GIh+5qAnRyyAmI16MSYgV24=; b=Ffvw9w4C65bDtwwQ7Q2h3oCds+ 0nC5skl6csud8Cpl/vCp6eg/AbzEdB/7/F6uvGbbk8lGS5O/cOzGRUh3eU/ttk3NV2BRJ33s/mgDk 0TCt4ySyi2Ik+Kno98BGj20ZD; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:58922 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hQBVs-003r8y-89; Mon, 13 May 2019 09:01:08 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH] Don't crash if parse_definition_macro's 'body' is NULL References: <20190510210425.2750-1-sergiodj@redhat.com> Date: Mon, 13 May 2019 14:01:00 -0000 In-Reply-To: <20190510210425.2750-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Fri, 10 May 2019 17:04:25 -0400") Message-ID: <871s124foc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00299.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> This very simple patch is just a safeguard against this scenario; it Sergio> is not a fix for the problem (which actually happens on "debugedit", Sergio> and which Mark Wielaard is already working on), but at least it makes Sergio> GDB not crash on invalid DWARF, which is a plus IMO. I don't really get why read_direct_string (and the other functions like it) returns NULL when it sees an empty string. How is something like "#define X" represented such that this doesn't return NULL? Other complaints in the caller of parse_macro_definition provide a bit more context, like the macro name, source file, and line number: complaint (_("debug info gives %s macro %s with %s line %d: %s"), at_commandline ? _("command-line") : _("in-file"), is_define ? _("definition") : _("undefinition"), line == 0 ? _("zero") : _("non-zero"), line, body); ... so maybe the new complaint could as well. Tom