Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org,  Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH][gdb] Fix heap-buffer-overflow in cp_find_first_component_aux
Date: Wed, 29 May 2019 18:55:00 -0000	[thread overview]
Message-ID: <871s0hxf8t.fsf@tromey.com> (raw)
In-Reply-To: <20190525093527.GA2911@delia> (Tom de Vries's message of "Sat, 25	May 2019 11:35:29 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> [gdb] Fix heap-buffer-overflow in cp_find_first_component_aux

Tom> gdb/ChangeLog:

Tom> 2019-05-25  Tom de Vries  <tdevries@suse.de>

Tom> 	PR gdb/24618
Tom> 	* dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
Tom> 	sure an empty slot (defined by a 32-bit zero pair) is recognized as
Tom> 	invalid.

Thanks for the patch and the excellent analysis.

I looked at the history here a little and the earlier code did:

-      if (bucket.name == 0 && bucket.vec == 0)

... so this seems to have just been a simple error in the patch.

This is ok, please check it in.

Tom


  reply	other threads:[~2019-05-29 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-25  9:35 Tom de Vries
2019-05-29 18:55 ` Tom Tromey [this message]
2019-05-31 12:54   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s0hxf8t.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox