From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104541 invoked by alias); 28 Jun 2019 14:53:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104473 invoked by uid 89); 28 Jun 2019 14:53:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SEMBLACK,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=HTo:U*palves X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.97) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jun 2019 14:53:32 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 92F27EC43F for ; Fri, 28 Jun 2019 09:53:27 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gsFjhAn0UdnCegsFjhk3uO; Fri, 28 Jun 2019 09:53:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jZg3yKQEDYjziE8cL/BOVMC/gpCaF4T0JbyyTWWlqZU=; b=h7ljlVTlf5GvgdQ/3jY9dSZ1zA XlsQJr2U7ZJn5pMt4Jjg+Gj6aMfZTZkbtKh0cTyP5G4aEG3VyYJCXBCfWl6IGZow2Y98lQVx9G4wU XyHvRVHWxYkoN+F26cRIUP0BB; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:50318 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hgsFj-002Wcm-51; Fri, 28 Jun 2019 09:53:27 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/5] Fix latent bug in test_gdb_complete_cmd_multiple References: <20190627191427.20742-1-palves@redhat.com> <20190627191427.20742-5-palves@redhat.com> Date: Fri, 28 Jun 2019 14:53:00 -0000 In-Reply-To: <20190627191427.20742-5-palves@redhat.com> (Pedro Alves's message of "Thu, 27 Jun 2019 20:14:26 +0100") Message-ID: <871rzd223d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00630.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> if {$max_completions} { Pedro> + set cmd_prefix_re [string_to_regexp $cmd_prefix] Pedro> append expected_re \ Pedro> - "$cmd_prefix \\*\\*\\* List may be truncated, max-completions reached\\. \\*\\*\\*.*\r\n" Pedro> + "$cmd_prefix_re \\*\\*\\* List may be truncated, max-completions reached\\. \\*\\*\\*.*\r\n" Pedro> } Pedro> set cmd_re [string_to_regexp "complete $cmd_prefix$completion_word"] It looks like this is going to end up running string_to_regexp twice -- once in the "if" and then again here, which is probably not desirable. Tom