From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65425 invoked by alias); 21 Aug 2019 17:45:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60494 invoked by uid 89); 21 Aug 2019 17:45:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HTo:U*uweigand X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 17:45:26 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7LHhItO085343 for ; Wed, 21 Aug 2019 13:45:18 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 2uh87kem9v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 21 Aug 2019 13:45:18 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7LHjGDt006852 for ; Wed, 21 Aug 2019 17:45:17 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma04dal.us.ibm.com with ESMTP id 2ue9775j0s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 21 Aug 2019 17:45:17 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7LHjETa20316424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Aug 2019 17:45:14 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC17BBE061; Wed, 21 Aug 2019 17:45:14 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70DD6BE059; Wed, 21 Aug 2019 17:45:14 +0000 (GMT) Received: from pedro.localdomain (unknown [9.18.235.64]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 21 Aug 2019 17:45:14 +0000 (GMT) Received: by pedro.localdomain (Postfix, from userid 1000) id 6A57A3C0348; Wed, 21 Aug 2019 14:44:54 -0300 (-03) From: Pedro Franco de Carvalho To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] [PowerPC] Fix debug register issues in ppc-linux-nat In-Reply-To: <20190821153133.B457CD802EF@oc3748833570.ibm.com> References: <20190821153133.B457CD802EF@oc3748833570.ibm.com> Date: Wed, 21 Aug 2019 17:45:00 -0000 Message-ID: <871rxefm5m.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00498.txt.bz2 "Ulrich Weigand" writes: > The one question I still have is, given that we'll be deleting the > installed breakpoints after a clone/fork anyway, wouldn't it be > easier to just *delete* all breakpoints directly at the clone/fork > callback and start out the GDB "installed" structures as empty? > But that's just a minor detail ... whatever is easier to implement > is fine with me. I think it's easier to do it in prepare_to_resume, since we have to do it there anyway to handle hardware breakpoints that were removed by the user. I'm also not sure that linux-nat is prepared to take exceptions from these callbacks, in case a ptrace call there fails. > Since this really seems to be required on PowerPC due to the peculiar > ptrace interface, I'm fine with adding the common code clone hook. Ok. Is it acceptable if linux-low in gdbserver doesn't have the equivalent hook? Adding one there would require changing struct linux_target_ops and every arch that uses it. This will become necessary in the future to enable hardware breakpoints in the ppc server stub. Thanks! -- Pedro Franco de Carvalho > > Thanks, > Ulrich > > -- > Dr. Ulrich Weigand > GNU/Linux compilers and toolchain > Ulrich.Weigand@de.ibm.com