From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119414 invoked by alias); 20 Feb 2020 19:43:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119406 invoked by uid 89); 20 Feb 2020 19:43:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 19:43:22 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 4E4681D4B2E for ; Thu, 20 Feb 2020 13:43:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4rjEjfsrySl8q4rjEjMAXG; Thu, 20 Feb 2020 13:43:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LBJHDmavWMi/03SUvG+QfZyGmpggM2WySdHQO2NVieY=; b=FGWzdbeCLflWX21lMkbRTjIhcF A/JUJ9YFqWS4fa8GTimYN981DrHVxbPT8857QDT5kSMTQoByOpuMwPxETjAFp8qVg5GTtUX9p/D4d XC6ybCKe9uIUW1mo2bTKj3PpG; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:57714 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j4rjE-002W1O-1Y; Thu, 20 Feb 2020 12:43:20 -0700 From: Tom Tromey To: Simon Marchi Cc: Aaron Merey , gdb-patches@sourceware.org, Tom Tromey , Christian Biesinger Subject: Re: [PATCH v3] Add debuginfod support to GDB References: <4d971725-4f83-a1d3-80a2-9e54a78c6e56@simark.ca> Date: Thu, 20 Feb 2020 19:43:00 -0000 In-Reply-To: <4d971725-4f83-a1d3-80a2-9e54a78c6e56@simark.ca> (Simon Marchi's message of "Thu, 20 Feb 2020 13:50:10 -0500") Message-ID: <871rqphwo8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00837.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2020-02-20 1:02 p.m., Simon Marchi wrote: >> I think we still need something just after the debuginfod_find_debuginfo >> and debuginfod_find_source calls to throw the "quit" exception, if the quit >> flag is set at this point. Without that, the debuginfod_source_query and >> debuginfod_debuginfo_query will return a failure. The calling code could >> therefore conclude that debug info is not available (and cache that value >> somehwere), for a file for which debug info is actually available. When >> the execution reaches the event loop and we process the quit flag, it >> would be too late, the damage will have been done. Simon> Following a discussion on IRC, I changed my mind, the simplest solution Simon> for now would be: when the user cancels a download, GDB will continue Simon> as if debug info was not available for that objfile. However, I would suggest Simon> printing a message saying that the download of debug info for XYZ was cancelled, Simon> so the user is not surprised to not have its debug info. Wouldn't this imply also clearing (or more precisely - not preserving) the quit flag in the interrupt case? It seems to me that as long as the interrupt is processed by the library, then we wouldn't want to set the quit flag again. Otherwise that will look like a double interrupt. Tom