From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59812 invoked by alias); 28 Feb 2020 19:47:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59803 invoked by uid 89); 28 Feb 2020 19:47:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*f:sk:8051c51, H*i:sk:8051c51 X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 19:47:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582919262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNDCdblLSouERTra8DzIGNv9wQ80HXqVXI5nVUrJy6M=; b=Z0ZVZHDGvx5MWsGobWjWVCb5ml00nzKm4QmzRvj6X5OlvBSP841jr3HoZos5I4+IM9Ax9I uO+bA6qRqpNPoPKPOzqsKNO5b543JSg8+uVRlr60H4GNN7jO3wVm1IHpLlXlCk1EichrCB rQcn/D1fePNNHWuUzaom0BqFlBWb0Mo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-FPZ8x-YYMGyABoOSf4Ez5w-1; Fri, 28 Feb 2020 14:47:34 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40B1B8017DF; Fri, 28 Feb 2020 19:47:33 +0000 (UTC) Received: from localhost (unused-10-15-17-54.yyz.redhat.com [10.15.17.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 007CE19C7F; Fri, 28 Feb 2020 19:47:32 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , Tom Tromey , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH 1/6] Introduce scoped_pipe.h References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-2-sergiodj@redhat.com> <8051c51b-da71-68b7-877a-82322475a133@redhat.com> Date: Fri, 28 Feb 2020 19:47:00 -0000 In-Reply-To: <8051c51b-da71-68b7-877a-82322475a133@redhat.com> (Pedro Alves's message of "Fri, 28 Feb 2020 19:19:49 +0000") Message-ID: <871rqeqysr.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg01068.txt.bz2 On Friday, February 28 2020, Pedro Alves wrote: > On 2/26/20 8:05 PM, Sergio Durigan Junior wrote: > >> --- /dev/null >> +++ b/gdb/unittests/scoped_pipe-selftests.c >> @@ -0,0 +1,96 @@ > >> + >> +#include "defs.h" >> + >> +#include "gdbsupport/scoped_pipe.h" >> +#include "config.h" > > Was there a reason for this "config.h" include? I copied this test from the existing scoped_fd-selftests.c and adjusted it. I did remove other includes, but left this one untouched. I tried removing it now, and the file builds just fine, so I'll update my copy of the patch here. Thanks! --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/