From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Rename the read symbol to xread
Date: Wed, 18 Mar 2020 14:51:35 -0600 [thread overview]
Message-ID: <871rppv12g.fsf@tromey.com> (raw)
In-Reply-To: <be71b40b-d223-4280-059e-4fe725e7f86a@simark.ca> (Simon Marchi's message of "Tue, 17 Mar 2020 20:43:28 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 2020-03-17 7:57 p.m., Kamil Rytarowski wrote:
>> This avoids clashes with macro read in the NetBSD headers.
Simon> This is ok to push. OOC, this is the only spot in the whole GDB code base
Simon> that has this problem?
There are several other "read" symbols. I thought in C++ this sort of
thing was valid, so I guess that's a NetBSD bug of a sort.
Perhaps "#undef read" would be better overall.
Tom
prev parent reply other threads:[~2020-03-18 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 12:45 [PATCH] " Kamil Rytarowski
2020-03-17 17:51 ` Christian Biesinger
2020-03-17 17:58 ` Kamil Rytarowski
2020-03-17 18:00 ` Christian Biesinger
2020-03-17 18:01 ` Kamil Rytarowski
2020-03-17 18:59 ` Christian Biesinger
2020-03-17 23:57 ` [PATCH v2] " Kamil Rytarowski
2020-03-18 0:43 ` Simon Marchi
2020-03-18 1:01 ` Kamil Rytarowski
2020-03-18 20:51 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rppv12g.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox