From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.144]) by sourceware.org (Postfix) with ESMTPS id 401D53875DFD for ; Fri, 20 Mar 2020 15:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 401D53875DFD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 8E556A904 for ; Fri, 20 Mar 2020 10:43:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id FJoLjUSkPEfyqFJoLjUJiV; Fri, 20 Mar 2020 10:43:49 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1h04f3wd868y/ZONQaAhw848iIMEx6JJsUGCbW+/zdQ=; b=PTu8uWwYTCnmVUQ+3TkCx88yiu AuqqQxthwZqG8MRmAfz4yYYoseS96dcd9Ouu2/Ap0OfbqO0a5RX1ppza5JdF7iclKhaZoDoXxFiG/ oWK6nrsb+sHPV0H9ipiAN++0l; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:43026 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jFJoL-000FOD-Bn; Fri, 20 Mar 2020 09:43:49 -0600 From: Tom Tromey To: Kamil Rytarowski Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH v2] Add support for "info auxv" on NetBSD References: <20200314182258.4277-1-n54@gmx.com> <20200316181710.7542-1-n54@gmx.com> X-Attribution: Tom Date: Fri, 20 Mar 2020 09:43:48 -0600 In-Reply-To: <20200316181710.7542-1-n54@gmx.com> (Kamil Rytarowski's message of "Mon, 16 Mar 2020 19:17:10 +0100") Message-ID: <871rpnm3pn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jFJoL-000FOD-Bn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:43026 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_3, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 15:43:51 -0000 >>>>> "Kamil" == Kamil Rytarowski writes: Kamil> Register nbsd_auxv_parse() that overloads the default (Linux-style) Kamil> AUXV parsing. On NetBSD the type parameter is defined as int32_t Kamil> for all architectures. Thanks for the patch. Kamil> + Kamil> +static int Kamil> +nbsd_auxv_parse (struct gdbarch *gdbarch, gdb_byte **readptr, Kamil> + gdb_byte *endptr, CORE_ADDR *typep, CORE_ADDR *valp) In gdb a new function should always have an intro comment. This one could just explain which gdbarch callback it implements. Kamil> +{ Kamil> + struct type *int_type = builtin_type (gdbarch)->builtin_int; Presumably you want builtin_in32 here? builtin_int is architecture-dependent. Or you could just hard-code the size, with a suitable comment. Kamil> + Kamil> +void Kamil> +nbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) The intro comment here should probably say "See nbsd-tdep.h."... Kamil> +++ b/gdb/nbsd-tdep.h Kamil> @@ -25,4 +25,6 @@ struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void); Kamil> int nbsd_pc_in_sigtramp (CORE_ADDR, const char *); Kamil> +void nbsd_init_abi (struct gdbarch_info, struct gdbarch *); ... and then there should be a descriptive comment above this line. thanks, Tom