From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.91]) by sourceware.org (Postfix) with ESMTPS id 33135385BF92 for ; Wed, 1 Apr 2020 16:36:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33135385BF92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id D8FE581E08 for ; Wed, 1 Apr 2020 11:36:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JgM8jx7V5XVkQJgM8jBxfL; Wed, 01 Apr 2020 11:36:44 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BfuhUy0Ini07CA8rc+b5Ya4OVAa6enPf6ZFr6srXtBA=; b=oWbZ1pqtvyVtQMYDZOQv/k9Q3k yNtRxKmgmt6L0XFMEXIVVcqU//3jAgQU/utblVMyrgD2Ml59NDDMcu6gl+yZ4Y6oGxUrnL1sN7Wqh kHz9S6baRb3jB5/qbp0HYS/hJ; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:60304 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJgM8-0009Ox-J9; Wed, 01 Apr 2020 10:36:44 -0600 From: Tom Tromey To: Hannes Domani via Gdb-patches Subject: Re: [PATCH v2][PR gdb/24789] Allow pointer arithmetic with integer references References: <20200331220655.4436-1-ssbssa.ref@yahoo.de> <20200331220655.4436-1-ssbssa@yahoo.de> X-Attribution: Tom Date: Wed, 01 Apr 2020 10:36:43 -0600 In-Reply-To: <20200331220655.4436-1-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Wed, 1 Apr 2020 00:06:55 +0200") Message-ID: <871rp740ys.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jJgM8-0009Ox-J9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:60304 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 16:36:46 -0000 >>>>> "Hannes" == Hannes Domani via Gdb-patches writes: Hannes> 2020-04-01 Hannes Domani Hannes> PR gdb/24789 Hannes> * eval.c (is_integral_or_integral_reference): New function. Hannes> (evaluate_subexp_standard): Allow integer references in Hannes> pointer arithmetic. Thank you. Hannes> +/* Return true if type is integral or reference to integral */ Hannes> + Hannes> +static bool Hannes> +is_integral_or_integral_reference (struct type *type) Hannes> +{ Hannes> + if (is_integral_type (type)) Hannes> + return true; Hannes> + Hannes> + type = check_typedef (type); Hannes> + return type != nullptr Hannes> + && TYPE_IS_REFERENCE (type) Hannes> + && is_integral_type (TYPE_TARGET_TYPE (type)); This needs parens around the multi-line expression, like: return (type != nullptr && TYPE_IS_REFERENCE (type) && is_integral_type (TYPE_TARGET_TYPE (type))); The patch is ok with this tweak. Tom