From: Andreas Schwab <schwab@linux-m68k.org>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: fix -Wtautological-overlap-compare warning in mips-linux-tdep.c
Date: Sat, 16 May 2020 08:42:52 +0200 [thread overview]
Message-ID: <871rnkwfbn.fsf@linux-m68k.org> (raw)
In-Reply-To: <20200516020151.34919-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 15 May 2020 22:01:51 -0400")
On Mai 15 2020, Simon Marchi via Gdb-patches wrote:
> Indeed, given two different values, `insn` will always be different to
> one of them, and these conditions always be true. I suppose that the
> original intent was "if insn is equal to this instruction or equal to
> that instruction". Therefore the `!=` should be changed to `==`.
I don't think that makes sense. Rather || should be fixed to &&.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2020-05-16 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 2:01 Simon Marchi
2020-05-16 6:42 ` Andreas Schwab [this message]
2020-05-16 13:29 ` Maciej W. Rozycki
2020-05-16 15:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rnkwfbn.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox