From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Zaric@sourceware.org, Zoran <Zoran.Zaric@amd.com>
Subject: Re: [PATCH] gdb: replace function pointer with `void *` data with function_view
Date: Fri, 07 Aug 2020 14:54:47 -0600 [thread overview]
Message-ID: <871rkikwh4.fsf@tromey.com> (raw)
In-Reply-To: <20200807182916.1873936-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Fri, 7 Aug 2020 14:29:16 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> Replace the function pointer + `void *` parameters of
Simon> dwarf2_fetch_die_loc_sect_off and dwarf2_fetch_die_loc_cu_off with a
Simon> function_view parameter. Change call sites to use a lambda function.
Simon> This improves type-safety, so reduces the chances of errors.
Simon> gdb/ChangeLog:
Simon> * read.h (dwarf2_fetch_die_loc_sect_off,
Simon> dwarf2_fetch_die_loc_cu_off): Replace function pointer +
Simon> `void *` parameter with function_view.
Simon> * read.c (dwarf2_fetch_die_loc_sect_off,
Simon> dwarf2_fetch_die_loc_cu_off): Likewise.
Simon> * loc.c (get_frame_pc_for_per_cu_dwarf_call): Remove.
Simon> (per_cu_dwarf_call): Adjust.
Simon> (get_frame_address_in_block_wrapper): Remove.
Simon> (indirect_synthetic_pointer): Adjust.
Simon> (get_ax_pc): Remove.
Simon> (dwarf2_compile_expr_to_ax): Adjust.
Looks good, thanks.
Tom
next prev parent reply other threads:[~2020-08-07 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 18:29 Simon Marchi
2020-08-07 20:54 ` Tom Tromey [this message]
2020-08-09 22:28 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rkikwh4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Zaric@sourceware.org \
--cc=Zoran.Zaric@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox