From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kylFN39IrV/8TQAAWB0awg (envelope-from ) for ; Thu, 12 Nov 2020 09:36:47 -0500 Received: by simark.ca (Postfix, from userid 112) id D58641F08B; Thu, 12 Nov 2020 09:36:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7B7B51E552 for ; Thu, 12 Nov 2020 09:36:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C740D3846078; Thu, 12 Nov 2020 14:36:46 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.94]) by sourceware.org (Postfix) with ESMTPS id D48B43858034 for ; Thu, 12 Nov 2020 14:36:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D48B43858034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 2753C153456 for ; Thu, 12 Nov 2020 08:36:43 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dDiNkhidViQiZdDiNkS2yu; Thu, 12 Nov 2020 08:36:43 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uj0KcysioUAMl3fLLwv8MtbjVsCia4UY4adf+0MPJiw=; b=nd8rXsJnXECfuPscejAb7HUERk fcsEE8krycFuP0nZU3Vgd2c4Ca8LC9HGT812JMno4KFz3IX+FucGVMQnoKz2rcYOPzvSi9YS04z7p 1HZkPlEzPWw0DYpAjBWq359MV; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:35012 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kdDiM-0026lX-RX; Thu, 12 Nov 2020 07:36:42 -0700 From: Tom Tromey To: Shahab Vahedi via Gdb-patches Subject: Re: [PATCH] arc: Write correct "eret" value during register collection References: <20201112134310.8544-1-shahab.vahedi@gmail.com> X-Attribution: Tom Date: Thu, 12 Nov 2020 07:36:42 -0700 In-Reply-To: <20201112134310.8544-1-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 12 Nov 2020 14:43:10 +0100") Message-ID: <871rgyfxqd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kdDiM-0026lX-RX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:35012 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shahab Vahedi , Shahab Vahedi , Francois Bedard Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Shahab" == Shahab Vahedi via Gdb-patches writes: Shahab> * arc-linux-tdep.c (collect_register): Use "eret" value while Shahab> still writing to "pc" register cache. Shahab> collect_register (const struct regcache *regcache, struct gdbarch *gdbarch, Shahab> int regnum, gdb_byte *buf) Shahab> { Shahab> + int offset; Shahab> + Shahab> /* Skip non-existing registers. */ Shahab> - if ((arc_linux_core_reg_offsets[regnum] == ARC_OFFSET_NO_REGISTER)) Shahab> + if (arc_linux_core_reg_offsets[regnum] == ARC_OFFSET_NO_REGISTER) Shahab> return; Shahab> + else Shahab> + offset = arc_linux_core_reg_offsets[ARC_ERET_REGNUM]; I would drop the "else" here. I didn't understand this patch. It unconditionally sets 'offset' to the offset of ARC_ERET_REGNUM. But surely that can't be correct? The assignment above does this, and so does... Shahab> if (regnum == gdbarch_pc_regnum (gdbarch)) Shahab> - regnum = ARC_ERET_REGNUM; Shahab> - regcache->raw_collect (regnum, buf + arc_linux_core_reg_offsets[regnum]); Shahab> + offset = arc_linux_core_reg_offsets[ARC_ERET_REGNUM]; ... this one. Tom