From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AyjpFO6rAWF4JgAAWB0awg (envelope-from ) for ; Wed, 28 Jul 2021 15:11:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 4687A1EDFB; Wed, 28 Jul 2021 15:11:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5D6F1E813 for ; Wed, 28 Jul 2021 15:11:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59665398AC29 for ; Wed, 28 Jul 2021 19:11:41 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.224]) by sourceware.org (Postfix) with ESMTPS id 321AB3959E5D for ; Wed, 28 Jul 2021 19:11:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 321AB3959E5D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 87F9934DF0 for ; Wed, 28 Jul 2021 14:11:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8owXmj4a3sCiy8owXmPCzw; Wed, 28 Jul 2021 14:10:14 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bgfEENwU0sWZAI4PMonuutMzmdK8BagWhZLfa9dqHaM=; b=Dp1hwpRo/Pb5ISA0guiKA/d97y 15qW5opzUwNU8prGrMGdUEBG6jWTddoZbZ3pDOGDvRoj6Qh0pHiUTQe3P9/lk60WYoEfp0nVkmjYL +C6HwIUxD/PkvPJdkOq14K3rF; Received: from 97-122-74-117.hlrn.qwest.net ([97.122.74.117]:35710 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8owX-00235e-13; Wed, 28 Jul 2021 13:10:13 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 13/16] gdb: remove cmd_list_element::function::sfunc References: <20210714045520.1623120-1-simon.marchi@polymtl.ca> <20210714045520.1623120-14-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 28 Jul 2021 13:10:12 -0600 In-Reply-To: <20210714045520.1623120-14-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Wed, 14 Jul 2021 00:55:17 -0400") Message-ID: <871r7idzl7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.74.117 X-Source-L: No X-Exim-ID: 1m8owX-00235e-13 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-74-117.hlrn.qwest.net (murgatroyd) [97.122.74.117]:35710 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I don't understand what the sfunc function type in Simon> cmd_list_element::function is for. Thanks for cleaning this stuff up. My feeling is that, probably, some of this was from a planned transition that was never completed. It's hard to know for sure though. Simon> int Simon> cli_user_command_p (struct cmd_list_element *cmd) Simon> { Simon> - return (cmd->theclass == class_user Simon> - && (cmd->func == do_simple_func || cmd->func == do_sfunc)); Simon> + return cmd->theclass == class_user && cmd->func == do_simple_func; This seems to change the semantics of this function, but I wonder if it matters at all. (Ideally, though, cli_user_command_p would simply go away.) Tom