From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 97KQLDJiimdCVxIAWB0awg (envelope-from ) for ; Fri, 17 Jan 2025 08:59:14 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SOhW2k74; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A820B1E100; Fri, 17 Jan 2025 08:59:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C36141E08E for ; Fri, 17 Jan 2025 08:59:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FBFA3847702 for ; Fri, 17 Jan 2025 13:59:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FBFA3847702 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SOhW2k74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D79EF384781B for ; Fri, 17 Jan 2025 13:58:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D79EF384781B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D79EF384781B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737122310; cv=none; b=XZ//dLArjJ2GMHBXvBzOTZHKJYch6aaWY+l0GpIrFf/mi/epSsph09mloDZXwFquQUMe9ro3kjYenhqYM0aSByZnG2nGCpomFGMDFZiDaTm6Khi0BjS5b2hTs4pEbPz7eL1T5BUO5S3y2x144yBB93lYOWCRRCkWpq9t/dhTiuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737122310; c=relaxed/simple; bh=r7wPNoYrncvIE8Nf8YFUyPSiC19/wQa29tx5T1jPc2k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Tj0lX1RAce5m1/5zfOI9FIl5ZpZhllAjTRgElVKYl4v/2aLVa0ogffGRlZvJ7B+/gbmMsVstz4ACATpiQHxDXOPDfBVPz69E5trSqYBav2KMPXMVLbSohecwBkfz9bnK36bRiOJSrbXjy839bcBfgI4Hc3UXZ8PpPI6imTd7kRc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D79EF384781B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737122310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6Tou3ik/78RcWcYJBGQ8aNh1zHv9jrgxCZ0aypIaBwk=; b=SOhW2k746slzQbIMs8OcBAqrHjyVHNpt1kLOnZ4dllaiHJIi+XZue027Hsmh3JXDuqQlcd UZGkjy/xgd7SNmCKUUuy5cCVCWka/FjKiEPc/XbHJVv9N/nkuwmtFodotX+ONa/i61I/6g uLISpSRDmEfZTlX2ZZFfuBX5njWnM8g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-YvzZtob2NxWbXp-0G1o4-g-1; Fri, 17 Jan 2025 08:58:29 -0500 X-MC-Unique: YvzZtob2NxWbXp-0G1o4-g-1 X-Mimecast-MFC-AGG-ID: YvzZtob2NxWbXp-0G1o4-g Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385e00ebb16so887174f8f.3 for ; Fri, 17 Jan 2025 05:58:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737122308; x=1737727108; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Tou3ik/78RcWcYJBGQ8aNh1zHv9jrgxCZ0aypIaBwk=; b=Xey+LO8EHcEdk0YUuHmgCI7kCuimCpN9XlWtB/O6lONVcBQTDTdch7YHdSt/hbSIO8 P0ZA2bllN+oZpkip89rl0Gzw3Yldcb/k90Us+P7ok3XY8H44TdwMY9FRSCLOUvJi0w41 My7C7qrKSU56htfA8AcM9u/xr6NSmJhpRO175ClITvLS1+lSwOw3InIHF93V9K9aMz9R 0d814wghKzudYGV7fZjKvXsuI/wjsfFjMxExnQYsIp0MNaiRexAMPUHgVq9CBNakIDr8 ka6HWWflBuBn3Kkg8b0P8IFVmIK+6TtX6aq/c5yZ5e4kigwAq2LPnDeloXVB4qFA7O/Y 1sNw== X-Forwarded-Encrypted: i=1; AJvYcCX+SS3bAtp+BfZ1PhRRIEeMbCeQ+KfrBfcd3coSutB0DeTVtnyacbfFHoQdW/MUfzMFVaHbRDeOtHybMA==@sourceware.org X-Gm-Message-State: AOJu0YyEW4NXZxiPYWvqJQi9BM5TTQQUX+qABf3iyRhkVsZgab6Z0F5x DPtRA78kP3tRUqYJjE8IAc9wlfV5JPm0OQUktTUHkhaADXV4SVVWm7jUUu3OsEvLvQfbUZkWLrp UIB1dVY15hETI/d/ywQ7lB35Y3I8EsIqsXnZLgk+21YooTcSnEQG8JzFpas9DDkZyv1U= X-Gm-Gg: ASbGncvFUbezXePY7u9T6sTKM1DqehvCbRzrhRknnwwOtBKzgWOYc+BKfJ+qXryQ2PY Lf7e95qsbmDaaVVWf/+VzQ2wcaIiCW4wLEZlOlGgkzfOUFLvoD9KFOu7B2MW32T7Qq8vhtGKSx3 moNoAnK6IMDh5iBopfBcypuzS+3ogG+Pll6xDqS+PvXFksvQ0ar40uR5eABxwpaxXGbkTLAHRda teWOG5U7+pzkCX+8twaSqBeBQVnkJYs1qfHERXTDqaZgaAYL7JqBvVrWG5/XnGCxoPdKrorqD5g fQ+sXA== X-Received: by 2002:a5d:648a:0:b0:38b:f44b:8663 with SMTP id ffacd0b85a97d-38bf57c0ac9mr2292049f8f.55.1737122308028; Fri, 17 Jan 2025 05:58:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEA9c6pivpDfKTKh5SRr+1FhfwIGzVl0BAkn1F/FFLqngY//S8f+dipY2+4DZ/U0C1a5vBzTQ== X-Received: by 2002:a5d:648a:0:b0:38b:f44b:8663 with SMTP id ffacd0b85a97d-38bf57c0ac9mr2292023f8f.55.1737122307558; Fri, 17 Jan 2025 05:58:27 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3215bf2sm2647671f8f.18.2025.01.17.05.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 05:58:27 -0800 (PST) From: Andrew Burgess To: Guinevere Larsen , gdb-patches@sourceware.org Cc: Jan Kratochvil , Thiago Jung Bauermann Subject: Re: [PATCH v8 5/5] gdb/testsuite: Test for a backtrace through object without debuginfo In-Reply-To: <1e245705-4936-48ac-8ec5-691f945e8766@redhat.com> References: <20241210195115.3046370-1-guinevere@redhat.com> <20241210195115.3046370-6-guinevere@redhat.com> <877c6uq0y9.fsf@redhat.com> <1e245705-4936-48ac-8ec5-691f945e8766@redhat.com> Date: Fri, 17 Jan 2025 13:58:26 +0000 Message-ID: <871px1o83h.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HvOdVJcAs3g6LA11hYkqCc7ga5QJKpGVuBsx2aLDsU0_1737122308 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > On 1/16/25 11:37 AM, Andrew Burgess wrote: >> Guinevere Larsen writes: >> >>> Fedora has been carrying this test since back in the Project Archer >>> days. A change back then caused GDB to stop being able to backtrace when >>> only some of the object files had debug information. Even though the >>> changed code never seems to have made its way into the main GDB project, >>> I think it makes sense to bring the test along to ensure something like >>> this doesn't pass unnoticed. >>> >>> Co-Authored-By: Jan Kratochvil >>> Reviewed-by: Thiago Jung Bauermann >>> --- >>> .../backtrace-through-cu-nodebug-caller.c | 28 ++++++ >>> .../backtrace-through-cu-nodebug-main.c | 32 +++++++ >>> .../gdb.base/backtrace-through-cu-nodebug.exp | 95 +++++++++++++++++++ >>> 3 files changed, 155 insertions(+) >>> create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c >>> create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c >>> create mode 100644 gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >>> >>> diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c >>> new file mode 100644 >>> index 00000000000..3a63d72a468 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-caller.c >>> @@ -0,0 +1,28 @@ >>> +/* This testcase is part of GDB, the GNU debugger. >>> + >>> + Copyright 2005-2024 Free Software Foundation, Inc. >>> + >>> + This program is free software; you can redistribute it and/or modify >>> + it under the terms of the GNU General Public License as published by >>> + the Free Software Foundation; either version 3 of the License, or >>> + (at your option) any later version. >>> + >>> + This program is distributed in the hope that it will be useful, >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + GNU General Public License for more details. >>> + >>> + You should have received a copy of the GNU General Public License >>> + along with this program. If not, see . */ >>> + >>> +typedef int (*callback_t) (void); >>> + >>> +int >>> +caller (callback_t callback) >>> +{ >>> + /* Ensure some frame content to push away the return address. */ >>> + volatile const long one = 1; >>> + >>> + /* Modify the return value to prevent any tail-call optimization. */ >>> + return (*callback) () - one; >>> +} >>> diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c >>> new file mode 100644 >>> index 00000000000..3e7ac57a166 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug-main.c >>> @@ -0,0 +1,32 @@ >>> +/* This testcase is part of GDB, the GNU debugger. >>> + >>> + Copyright 2005-2024 Free Software Foundation, Inc. >>> + >>> + This program is free software; you can redistribute it and/or modify >>> + it under the terms of the GNU General Public License as published by >>> + the Free Software Foundation; either version 3 of the License, or >>> + (at your option) any later version. >>> + >>> + This program is distributed in the hope that it will be useful, >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + GNU General Public License for more details. >>> + >>> + You should have received a copy of the GNU General Public License >>> + along with this program. If not, see . */ >>> + >>> +typedef int (*callback_t) (void); >>> + >>> +extern int caller (callback_t callback); >>> + >>> +int >>> +callback (void) >>> +{ >>> + return 1; >>> +} >>> + >>> +int >>> +main (void) >>> +{ >>> + return caller (callback); >>> +} >>> diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >>> new file mode 100644 >>> index 00000000000..c0940b406a8 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp >>> @@ -0,0 +1,95 @@ >>> +# Copyright 2010-2024 Free Software Foundation, Inc. >> Remember to update the copyright year throughout. >> >>> + >>> +# This program is free software; you can redistribute it and/or modify >>> +# it under the terms of the GNU General Public License as published by >>> +# the Free Software Foundation; either version 3 of the License, or >>> +# (at your option) any later version. >>> +# >>> +# This program is distributed in the hope that it will be useful, >>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> +# GNU General Public License for more details. >>> +# >>> +# You should have received a copy of the GNU General Public License >>> +# along with this program. If not, see . >>> + >>> +# Test that GDB can generate accurate backtraces even if some of the stack >>> +# trace goes through a function with no debug information. >>> + >>> +standard_testfile -caller.c -main.c >>> +set objmainfile ${testfile}-main.o >>> +set objcallerfile ${testfile}-caller.o >>> + >>> +# recompile the inferior with or without CFI information, then run the >>> +# inferior until the point where the important test starts >>> +# returns TRUE on an ERROR. >> Needs converting to two sentences ('.' after 'starts'). Plus capital >> 'R' for each sentence. >> >> I wonder if it would be better to return TRUE on success, and FALSE on >> error, because .... see below ... >> >>> +proc prepare_test {has_cfi} { >>> + global srcdir subdir srcfile srcfile2 objmainfile objcallerfile binfile >>> + if {$has_cfi} { >>> + set extension "cfi" >>> + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ >>> + "${srcdir}/${subdir}/${objcallerfile}" \ >>> + object [list {additional_flags=-fomit-frame-pointer \ >>> + -funwind-tables -fasynchronous-unwind-tables}]] != "" } { >>> + untested "couldn't compile with cfi" >>> + return true >>> + } >>> + } else { >>> + set extension "no-cfi" >>> + if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ >>> + "${srcdir}/${subdir}/${objcallerfile}" \ >>> + object [list {additional_flags=-fomit-frame-pointer \ >>> + -fno-unwind-tables \ >>> + -fno-asynchronous-unwind-tables}]] != "" } { >>> + untested "couldn't compile without cfi" >>> + return true >>> + } >>> + } >>> + if {[gdb_compile [list "${srcdir}/${subdir}/${objmainfile}" \ >>> + "${srcdir}/${subdir}/${objcallerfile}"] \ >>> + "${binfile}-${extension}" binfile {}] != ""} { >>> + untested "couldn't link object files" >>> + return true >>> + } >>> + >>> + clean_restart "$binfile-${extension}" >>> + >>> + with_test_prefix "${extension}" { >>> + >>> + if ![runto callback] then { >>> + fail "has_cfi=$has_cfi: Can't run to callback" >>> + return true >>> + } >>> + gdb_test_no_output "maint frame-unwinder disable ARCH" >>> + return false >>> + } >>> +} >>> + >>> +if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" \ >>> + "${srcdir}/${subdir}/${objmainfile}" \ >>> + object {debug}] != "" } { >>> + untested "couldn't compile main file" >>> + return >>> +} >>> + >>> +if { [prepare_test false] } { >>> + untested ${testfile}.exp >>> +} else { >>> + gdb_test "bt" "Required frame unwinder may have been disabled.*" \ >>> + "verify unwind fail without CFI" >>> +} >> When something goes wrong with the prepare_test call we've already >> emitted an 'untested' or 'fail' message, thus I think we can just write: >> >> if { [prepare_test false] } { >> ... perform the test ... >> } >> >> Of course, this assumes that the true/false return value for >> prepare_test have been switched. Currently you'd write: >> >> if { ![prepare_test false] } { >> ... perform the test ... >> } >> >> which just seems weird. >> >> Also, the test here says "verify unwind fail without CFI". And we _do_ >> check for the error message about disabled unwinders. But if the `bt` >> worked this test would still pass just fine. We should probably be >> checking that we only print frame #0. Something like: >> >> gdb_test "bt" \ >> [multi_line \ >> "\[^\r\n\]+Required frame unwinder may have been disabled, \[^\r\n\]+" \ >> "#0\\s+callback \\(\\) \[^\r\n\]+"] \ >> "verify unwind fail without CFI" >> >> should do the job I think. >> >>> + >>> +if { [prepare_test true] } { >>> + untested ${testfile}.exp >>> +} else { >> Same suggestion here about avoiding the extra 'untested' call. >> >>> + if { [istarget "arm*-*-*"] } { >>> + setup_kfail backtrace/31950 *-*-* >>> + } >>> + set text {[^\r\n]+} >>> + # #0 callback () at ... >>> + # #1 0x00000000004004e9 in caller () >>> + # #2 0x00000000004004cd in main () at ... >>> + gdb_test "bt" \ >>> + "#0 +callback $text\r\n#1 $text in caller $text\r\n#2 $text in main $text" \ >>> + "verify unwinding works for CFI without DIEs" >> The test name here seems weird. Maybe: 'verify unwinding works for CUs >> without CFI' would be better? > > I applied all other suggestions. > > This naming came directly from the downstream patch, the point is to > parse a range described by a CFI but not by debug information. Ahh, OK. Not sure why I didn't grok that meaning yesterday. Maybe it's OK to just leave it then? Or maybe just s/DIEs/debug info/? > > What do you think about this wording: > 'Verify unwinding works based only on CFI information' Yeah, or that. Sorry, I think I was just being a bit slow when I read that yesterday! Thanks, Andrew > > ? > >> >> OK with these fixes. >> >> Approved-By: Andrew Burgess >> >> Thanks, >> Andrew >> >>> +} >>> -- >>> 2.47.0 > > > -- > Cheers, > Guinevere Larsen > She/Her/Hers