From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qe2UG5p5v2hZaTwAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 20:49:30 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Ic342Glc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6DE601E0BA; Mon, 08 Sep 2025 20:49:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D90861E047 for ; Mon, 08 Sep 2025 20:49:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5B4303858D35 for ; Tue, 9 Sep 2025 00:49:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B4303858D35 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Ic342Glc Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 009C33858CDB for ; Tue, 9 Sep 2025 00:48:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 009C33858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 009C33858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757378915; cv=none; b=rxARYf7+P+MCXfvIhqpCcpBvtSsLI9IjSbQ5+Ax4DEJb0KlG7EuzPI14EWP5gHPNgSPXjNfNFEmnn58uKr2Vc5CJvP7lo+KSfd4gdV3CZwRGAPUqcwmgjdQkTh+A79qvNfDmnNVogdMoTYM66GWqV4T038YaSAkgzvOhT6S8/4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757378915; c=relaxed/simple; bh=vjk+Gkec1qgvhDW3jruOsjx5XN4BEcUbx3Kp2vi+ndM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ny35Jjdq/T7TDu7RI3bG7Oxu0BEhJsciOAb646Sp+RKv3l2s8MbVDg6ve8YVM1gBzA5ETW0dscsEhGN+q5m9gnlV3fx0p1Xkq6f9649ce5L5VkUC+OVD/aInlluz/vWc2utBGKVfvjggqp7CIgXF6NAAgv5EJnzIsy/VRMOVY/4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 009C33858CDB Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id veHyuXAPnv724vmXCu4i53; Tue, 09 Sep 2025 00:48:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id vmXCu7HvgWIZzvmXCu3tKp; Tue, 09 Sep 2025 00:48:34 +0000 X-Authority-Analysis: v=2.4 cv=M7JNKzws c=1 sm=1 tr=0 ts=68bf7962 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=f_FGAPiwAuNT12mb7sQA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ArtD7H9Zflwtx39EDOHTc27EES0FDrHAW8BV0pnmyig=; b=Ic342GlcTUozuWuuFosxz36cpw v9PKGzyQl817DK3nZLPrefa6A/KDl5haYCcjOJvPLYr5wvaHUN4smN9GEA499ut3a0hA1tGdUIHbz 4CvYx8jhErsR6sWvosa2/vNgg; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:43732 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uvmXB-00000000mUg-3egH; Mon, 08 Sep 2025 18:48:33 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Boolify line-program.c In-Reply-To: <445303b8-f7e3-47f8-a67b-588ad3a13a6f@simark.ca> (Simon Marchi's message of "Mon, 8 Sep 2025 13:07:10 -0400") References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-3-dd2beef9d475@tromey.com> <445303b8-f7e3-47f8-a67b-588ad3a13a6f@simark.ca> X-Attribution: Tom Date: Mon, 08 Sep 2025 18:48:32 -0600 Message-ID: <871pogih7j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uvmXB-00000000mUg-3egH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:43732 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMSH3xxWlgERjc2b2KB9rFXWr+RpDc/+RmrBL9glkWDzURHUz5jYkdXAt+UDA80K26m97DpDlw7XSb4K6QtAyavnE9rstut6TSvsNiYHbacV1DN3EGw8 j+yLZlp1/tPlqerF7qY0LDrKuYoaIA2Z4p76S4421+TcxVPRC7xmua63lrPUOKyb0pCgYiUIKDNAQSVsW0feN2J+awXDX26gOLU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> On 9/7/25 3:29 PM, Tom Tromey wrote: >> This changes some code in line-program.c to use bool rather than int. Simon> At the same time, I think you could fix the divergent intro comments Simon> (one in the header, one in the source file). I fixed the appended but the comment in the header looks correct to me? Anyway if you can point out what is wrong I will fix it. Tom diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c index 48ae4befd54..27356bd3e14 100644 --- a/gdb/dwarf2/line-program.c +++ b/gdb/dwarf2/line-program.c @@ -268,7 +268,7 @@ lnp_state_machine::handle_const_add_pc () % m_line_header->maximum_ops_per_instruction); } -/* Return non-zero if we should add LINE to the line number table. +/* Return true if we should add LINE to the line number table. LINE is the line to add, LAST_LINE is the last line that was added, LAST_SUBFILE is the subfile for LAST_LINE. LINE_HAS_NON_ZERO_DISCRIMINATOR is non-zero if LINE has ever