From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BFkqDc4m0Gg8EQ0AWB0awg (envelope-from ) for ; Sun, 21 Sep 2025 12:24:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BtgWXgEE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 245D31E04C; Sun, 21 Sep 2025 12:24:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB3701E04C for ; Sun, 21 Sep 2025 12:24:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 721F03858431 for ; Sun, 21 Sep 2025 16:24:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 721F03858431 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BtgWXgEE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 490483858431 for ; Sun, 21 Sep 2025 16:23:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 490483858431 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 490483858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758471823; cv=none; b=M9ekCZkeHd/E9y7+fvtFPyHOY7BfA61uLHNxjHEKnF2VIm5qrYTXmZK0xZu/BoOq1kfa7lv7/yO1ekVRqPPsz0fozMd35Oh5cM25AKyz3Eo4qq4qIuL84LtwH8ylOxMIAJk8aW93VOpF8ndNvQiZqFHo0TIv8Jv4J9JsTqe6oI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758471823; c=relaxed/simple; bh=mBPqY5RU+E1/DoUvSRmBZ5L7iKtkYnYldCfn8A6ISUY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=h9s2NTsf3FLJJX/anfKBfFkpnE6P8oPAB+P3wGENz+aDOmk7MQWuYTIVNd1mqreKx3YCcUydaausDpkYI/Dcc6gi60+rcBY+E14c/Z1hlaMSC0fefbpI894uy04BgOhikhWlrVaI1n5BGigfm3jVQ1ESSu4hGh0uzbU8tefg8EU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 490483858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758471823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aVAAfSS6NS2JOqVUCFU/jztut2bV1ooYE47rlimtpu4=; b=BtgWXgEEzGgu1cpwGsx2kJiHQa92wRpxzYiJEg/TOIwtIOyMOR0IDDyf5PZH3+Nwy0037V rE/dTLtJz3PVYNjfl2dskvm2Svq7LJuwSvMRi2hjQ+7MeM0rp9YZpflFNZeLIzOsk+a9t9 HrwvCpHqaK+atVuys4n2jhBx3N6b/jQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-sgaz2KE2PuKOPczWC6wvSw-1; Sun, 21 Sep 2025 12:23:41 -0400 X-MC-Unique: sgaz2KE2PuKOPczWC6wvSw-1 X-Mimecast-MFC-AGG-ID: sgaz2KE2PuKOPczWC6wvSw_1758471820 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4612d068c47so25387265e9.3 for ; Sun, 21 Sep 2025 09:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758471820; x=1759076620; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aVAAfSS6NS2JOqVUCFU/jztut2bV1ooYE47rlimtpu4=; b=BFeqtri6yBvRkaD1Sq+T37tL2nJ4SnSzU3MV9jkmTZNZ0x+1PvVJ+grxQcNZIRk6ro XiXFhtYpZvfbOgXS5d6vsUV56d1PD+6Ge0dEMoT6noySM19AQQzvA4+mD7sIODPMAxW9 v6bK4K0dH61zejCz0DVF1oxdpb8Ev7YeKCSOaHj3A4UFEUXPZSt4RPI4iVJSpSLVer35 w2zXAcjrf54jiA9643bpbsRXY8TSGhIEDBYzMnK4nigLW8uK0D2f6Sl/8RY9cII9TjJx G6n7PydSQoSUmvQiuyLryXtDk4aPWWwQZ4TEkScFoI8NoPJOYuAqPUQPEyPVRNzI6bGu cgVg== X-Forwarded-Encrypted: i=1; AJvYcCUkv4j6zIEbxTYtTA0pQTIqc8tEOeOxj5pJEsoVneE3VByW4IRBsEb6XaR02vp5mLq4NKvgOoTwtF3rbA==@sourceware.org X-Gm-Message-State: AOJu0Yyrso51TcvKSneHcd5EqT/+qyhV0m+PcFfJokUWiM757nkZyOsI 6f9jKiVa3No9TgzBhJSLV/fDzH5vTlL2q0Au2ehtO+6WjtMi+uesEH/ocS53mKgCCYAxxIBC2RI I4uVl19z3oojQlGkpHLhKTIqYUGva0JF9R6s3iPUg3plT6aPVrZkOlK9Rn3U4+TM= X-Gm-Gg: ASbGncv5jveE0s0baEPsV+TFawOuIELVnPZqsL6Vvj3raXCkxRiRnvik1omChHUGA2p kuVl8eyMF9dV3/hT9AmjuiC4QfdSH0rK1Ldx4G4T5Xfg9wJTlwU9wdpeAv9Tm/RvBe1WLzeB83M M3KQwlM/n3ZEQ0VASzGVx/ZaJwT0YGQE4XZNjGYkvetl/P6yQsL7wg+QxWm/f449x/UNtvF965E ClctVHuIgujRy4YKvqSwhSptvrorrMkjKVSUC17bp38OHjoZJTXId6q2KmfKrYrsxmKHXnu6EGR vzVh13ycmj8DbTdTTUDKVQlDhcdoet2HjHQ= X-Received: by 2002:a05:600c:4656:b0:45d:2ac9:4240 with SMTP id 5b1f17b1804b1-467f2242a93mr80787475e9.17.1758471820431; Sun, 21 Sep 2025 09:23:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRoSoICFt802A8YyeYNfH4A2wL5rrMY3u/wj1LtIVCiBdVgGJ6zA+YPlE080LA7IIRBXa6PA== X-Received: by 2002:a05:600c:4656:b0:45d:2ac9:4240 with SMTP id 5b1f17b1804b1-467f2242a93mr80787355e9.17.1758471820055; Sun, 21 Sep 2025 09:23:40 -0700 (PDT) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464f4f9f41csm185644585e9.15.2025.09.21.09.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Sep 2025 09:23:39 -0700 (PDT) From: Andrew Burgess To: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: new maintenance command to help debug remote argument issues In-Reply-To: <20250912165641.7a5b1512@f41-zbm-amd> References: <20250912165641.7a5b1512@f41-zbm-amd> Date: Sun, 21 Sep 2025 17:23:38 +0100 Message-ID: <871pnzhj05.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PACqIIn8j4wCLZRsqYyfnBFHwPkTYE4SKJOaNP5KKko_1758471820 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > On Fri, 12 Sep 2025 17:06:21 +0100 > Andrew Burgess wrote: > >> Add a new maintenance command 'maint test-remote-args', this command >> takes an argument string and splits it using gdb::remote_args::split >> and then joins the result using gdb::remote_args::join and prints all >> of the results. This is useful for diagnosing problems with remote >> argument passing. >> >> This new command is identical to what the remote argument self-tests >> do, but while I was working on improving remote argument passing it >> was far easier to have a command that I could just throw example >> strings at, rather than having to add new selftests and recompile >> GDB. >> >> I ended up adding a couple of additional helper functions to the >> gdb::argv_vec class. >> >> Reviewed-By: Eli Zaretskii >> Tested-By: Guinevere Larsen >> --- >> gdb/NEWS | 6 ++ >> gdb/doc/gdb.texinfo | 20 +++++++ >> gdb/remote.c | 60 +++++++++++++++++++ >> .../gdb.base/maint-test-remote-args.exp | 40 +++++++++++++ >> gdbsupport/gdb_argv_vec.h | 15 +++++ >> 5 files changed, 141 insertions(+) >> create mode 100644 gdb/testsuite/gdb.base/maint-test-remote-args.exp > > LGTM. > > Approved-By: Kevin Buettner Pushed. Thanks, Andrew