From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bZcwFuMbfWlBtx4AWB0awg (envelope-from ) for ; Fri, 30 Jan 2026 16:00:19 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=fx3TDgv7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3A59E1E08D; Fri, 30 Jan 2026 16:00:19 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A91131E08D for ; Fri, 30 Jan 2026 16:00:18 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1FB7A4BA23E9 for ; Fri, 30 Jan 2026 21:00:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FB7A4BA23E9 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=fx3TDgv7 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id B360F4BA2E1F for ; Fri, 30 Jan 2026 20:59:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B360F4BA2E1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B360F4BA2E1F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769806788; cv=none; b=cp8f/uscAn+KSZEO0OZBVeyij0wRarWZGBeLqcKPuqN5V1y7MVi+30oonUuh2sCmVaploSAZqAdjn0SP8sGVJ/V9n1TYkArciY6xd45IcANDwKG/b7fpnR86ZmpES5V8FS21txBbuM9GjmDbL+ugfIws9g32we5UDucpJ4n7oZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769806788; c=relaxed/simple; bh=rKLx5jHxpQR3COm8N6kk36/PWLZ2D8cyN7pMDKaG60g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KjZc1oTC8StKB3hTws+VPHJa0DmMrhOsGaRrjD/wzXpQRHHScnBxN4PvhiYSZdPoYnJRZCWr9ndy4/8rDcGt8EWBrSkQylr4VU/g9A/Pf1qvK9yX6y+PBXCscz/ZizsRKvOfjRUHsJSvGF/o5fqCj5gTxSlwiknc4zINMUibamY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B360F4BA2E1F Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id lsksvJfe3KjfolvalvZIoB; Fri, 30 Jan 2026 20:59:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id lvakvewrkOs9Rlvalv3kWY; Fri, 30 Jan 2026 20:59:47 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=697d1bc3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=G5NOfdjfVxPtPwN9iZoA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5JvKC9ff5v2hUvx75H26yM6D1rJPit6f8aNTq6BiAvc=; b=fx3TDgv7MF9XRJDhzvrYWcw49D YRZXJJOHEKMtm81Tk8WJOjvFGQRDpvbj4skbKHfr0DeItpY2pmP1xTxELKSQ9GOvxLiHxZXri2k33 ruoKYUPPXtAQoc8PIfx5wwvM2; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:35056 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vlvak-00000003wkM-2jku; Fri, 30 Jan 2026 13:59:46 -0700 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4] infcall: Add support for integer literals as reference function paramters In-Reply-To: <963c933a79455dc4aaa35f8c34bed8693065e6a5.1769539110.git.keiths@redhat.com> (Keith Seitz's message of "Tue, 27 Jan 2026 11:01:55 -0800") References: <92575c2eb6805095b41ebbe62ba99b81e4e5dd63.1760629738.git.keiths@redhat.com> <963c933a79455dc4aaa35f8c34bed8693065e6a5.1769539110.git.keiths@redhat.com> X-Attribution: Tom Date: Fri, 30 Jan 2026 13:59:45 -0700 Message-ID: <871pj695q6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vlvak-00000003wkM-2jku X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:35056 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOwuQ3j/Ri3fu1W0S7ZQ0n+8xdxjrKdq+fe/ysdRgozo420m3KJnWhW71GfqYQNlxa/4jaC65byl5dEAJP9xZjuQH5jd3pc/S0h6TsXZagE7j9QAYtOr Fjg6kuMPVl23DvY7dxG4Rz4P+Vk2CBAhkgZ/mLinms/zYCM0HBZFVed9rZLMtA3LTKyHbkODOcx6yemSP5R/FWp+TTxYIT/d0CE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Keith" == Keith Seitz writes: Keith> - Allocate to stack instead of heap I'm curious why this change was made. Often I think gdb just coerces to memory via malloc. Also other calls in this area seem to check thread_stack_temporaries_enabled_p. Not sure if that's needed? Maybe it's expected to be set and this can just be asserted? This is not really an area I know much about. Keith> + if (new_value->lval () != lval_memory Keith> + && language_pass_by_reference (new_value->type ()) Keith> + .trivially_copyable) This subexpression should be parenthesized and the '.' lined up with the 'l'. Tom