From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aaEtI5Xd8GmKTAEAWB0awg (envelope-from ) for ; Tue, 28 Apr 2026 12:17:25 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=k2NgFrnu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8C6A01E067; Tue, 28 Apr 2026 12:17:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 237291E067 for ; Tue, 28 Apr 2026 12:17:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AB27E4B920BF for ; Tue, 28 Apr 2026 16:17:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB27E4B920BF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=k2NgFrnu Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D87CF4B920BF for ; Tue, 28 Apr 2026 16:16:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D87CF4B920BF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D87CF4B920BF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777393019; cv=none; b=A4ln7wuOn7UyqyAIT1leKbypuvMba5Q8OKhir1MDv7+2XXDuPZ3pXupzPI51wzd/PmIp4g6HVTJZSaDjtjyaF5ZUp1sqee9UUPLPvS5ECh35mk9jKf1AJ0/yWZB5FkWiHSLt71yf0WUa/Hj8DpGeibDu+pCWsN58MjOciDMa2m0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777393019; c=relaxed/simple; bh=oKjo/RFbPKunKPVxIBXzwWa/JnFK0enAQBY3D0BSaY8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JS/QPbMAjsaIcHpXuhyhbFstwWjUqPlTI75P/hcthJYeybyuXF9CBcXlqP0gRvd9NNZmzRRM4lhvL11DGrHEshRah2JYVYBE1E1njdaqGX7Oe41B42JdzkhS9rG5Y0+7fOnyWbC8mkuCk6JyKn4T07tv5E9jsIVcOqtFQtk8PyM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D87CF4B920BF Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id HiFiwvHpPjw8YHl7Jw3EGZ; Tue, 28 Apr 2026 16:16:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Hl7DwjR16YO6jHl7Dw6ksr; Tue, 28 Apr 2026 16:16:51 +0000 X-Authority-Analysis: v=2.4 cv=ffyty1QF c=1 sm=1 tr=0 ts=69f0dd79 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=osvjErzaPgMvYsbsMioA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oKjo/RFbPKunKPVxIBXzwWa/JnFK0enAQBY3D0BSaY8=; b=k2NgFrnu8JP0zmHvVzSLBt3mvt dsxvLS0MrlYoQBYSlWchWcQpGsBKfn9qPnqt3yZ6PnmFjCjOWDPFK8VeWKo0mi3ab4bshAQsricyM 6WRgll+u+ztaO+pukvIbBZM0w; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:46828 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHl7C-00000003L6q-3xg2; Tue, 28 Apr 2026 10:16:51 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 02/11] gdb/solib: use early return in solib_read_symbols In-Reply-To: <20251209193610.296085-3-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 9 Dec 2025 14:32:06 -0500") References: <20251209193610.296085-1-simon.marchi@efficios.com> <20251209193610.296085-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 28 Apr 2026 10:16:49 -0600 Message-ID: <871pfzm55a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wHl7C-00000003L6q-3xg2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:46828 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIoJb6fZcou+VsWN+fog5bs97Gbx5OiYK0B4TsjRN5oPMNCxnEFFAQcikcp03c16Fjti406IrWs+U82zzYAQoL9X0ao6ZUE0ABrd4ZMZG5Bwag9ptU60 LTELoSEOl+tJXZVUk0CtvoEZI16bMdLGnhkQvg4kXAkx7cYqDB2vcFj+IJ8xAb6vc1GYxAP77LjUK+J/o6+ApSoqtov3B10v7kU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> From: Simon Marchi Simon> This reduces the indent a bit, and makes it clearer where the Simon> "interesting" part of the function is. Simon> At the same time, move the comment to solib.h. Ok. Approved-By: Tom Tromey Tom