From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8X1RItOHKWrD5T8AWB0awg (envelope-from ) for ; Wed, 10 Jun 2026 11:50:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e9VUmtXD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 82EEA1E0A3; Wed, 10 Jun 2026 11:50:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC6A81E070 for ; Wed, 10 Jun 2026 11:50:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C9E948FBC81 for ; Wed, 10 Jun 2026 15:50:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C9E948FBC81 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e9VUmtXD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 6DBA94BA2E13 for ; Wed, 10 Jun 2026 15:50:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DBA94BA2E13 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DBA94BA2E13 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781106610; cv=none; b=JINF9uKJJQZasnspMJJxJW/+mvbPOAbkXlOQXNH2ezwWTo94GYCqJAOXgl51jNMeSXw6CYEE12jEwXBfXBryU1+YCirkzf3Cuhnk3EZbvNNA2I/PD6u898YfZbTuHgwafE7w8mG53wUVn1QScrQCF0ht2CHCC+PaaDmC8VH4OnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781106610; c=relaxed/simple; bh=E/7WfnXLjuWwRAgwcQ1q41bGOFi5oF+u1hZPpQScLGc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ul6RSA+xtW3YlLILwYNh/JDTnREEIrCmSainghOxxl/dYAseEuSCOLg+ApPPKmsjInIrVrWI2De7tN7OZx9DurfgJ8TWxfdewhuRXoR/TGWAmWOxqYGg6NmohcS+o5hQS1jjPB7ZbRl1OIpNy7lLL4MpJKJ0MjDwEk9FRyDa3g8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e9VUmtXD DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DBA94BA2E13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781106610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ddjuQWE3NJPLSffTJrGkjWGtEsqnPTFWjrbmDRSKTGU=; b=e9VUmtXDYxNvGDkBZze9crms6a34yAzuLjwkAXJ3RaIRcDCcH+QiuGvqFNF5AvjFLYRDn8 BEoSNQpg5QvI0MMQtcsJcWgCaYx29v6eNie+Wumr/IiO6CWnKrI3ndzZ7SHdzpUWN6FDaB RZVZ3qBB7eXNg7ZsCz/bqCyjKlC+Ce4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-BRcp2Py4Pl6QZgzLt_UBzA-1; Wed, 10 Jun 2026 11:50:08 -0400 X-MC-Unique: BRcp2Py4Pl6QZgzLt_UBzA-1 X-Mimecast-MFC-AGG-ID: BRcp2Py4Pl6QZgzLt_UBzA_1781106607 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-45eecec7667so4907469f8f.3 for ; Wed, 10 Jun 2026 08:50:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781106607; x=1781711407; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ddjuQWE3NJPLSffTJrGkjWGtEsqnPTFWjrbmDRSKTGU=; b=d2HfX5eKuUJKeD7yHBQFcsGed7xMogESSJb9dL51befgpEUdvOckzALFXuP0PxnIBb 4k7MuBKcT69/sBw6lMj3FabUxIbRm9Xkdud5aZzlrxubsChHFNcwehgYBNANAEoSaZrZ AGA7AXV8zJkO1aCLVndkwTN1Iyg7hMMzSYk6S5qx6cHzPRpxaBnzC5uTIRRuu6NySv5+ CQqC8nzoOIfdHhn1z9pINXQne72A+YzWUV+j1juHuvh9a1ZIFXhblBlYOWI+lEHn4ixb g5qceG49nx5r42AqmTG09o7I7IUTXb3zGASKDJ9FEvfvW7Ym6pDb37pywJPReOYevg3X h+yw== X-Gm-Message-State: AOJu0YzKsBADw7txxDJ3Rhh+33sfmulKpF1kXi4tzo2ln7LIccidOVYe cad6uXXZuXdW6ieyT3YCLcaRCzh4m9TExqtK/C3j460WhCx4rWrZiTXjQhEt/mo/D4lZ5ucnXbf 0tSlOPNISNc1Zwe5rOWdAIfR3ECCfjwUdyGBPFPdr6gt4QDqGPAiP99IppNel/GA= X-Gm-Gg: Acq92OEUc+yOKybQ/a4BjgHtjIGR8NrJvde6yXt60X6VRiYQwstTZFRIf1iQR9+vlXN 8cGLTd90DQnGdLXVghYsgjUEDWA8/aYECQOiWdYhEkcqCPl5l7TRnQg8R2b0RLiI5vOYgaJTU22 q7oDVdKXtQFrptXEF/tJoq9Ov+Xro1Qd9aBFhndrnXo/UpbNFCaGuUdiryHJ0ZDpxCOhcmgwf6M ptKHSb8IVZLH+S/+IQZvdV/nsUdwt1/7d1mfMzSG7DUWcOpmMXD76aRfs1SzOCizLeEm/NA7Hu3 0sWZ15pFmzysNNKETPhnRT0z85yfzkKo62Y94FmXNykOt37LrHQKdTWIr/u72HLDSDvDPErZe+o abndVi0PDSVt69HtU3iuZP5eOFaqAIUbLvCo+keWi0S+9ThPUrtM= X-Received: by 2002:a5d:53cb:0:b0:45e:b215:12e9 with SMTP id ffacd0b85a97d-460302dcb18mr27740858f8f.6.1781106606881; Wed, 10 Jun 2026 08:50:06 -0700 (PDT) X-Received: by 2002:a5d:53cb:0:b0:45e:b215:12e9 with SMTP id ffacd0b85a97d-460302dcb18mr27740830f8f.6.1781106606466; Wed, 10 Jun 2026 08:50:06 -0700 (PDT) Received: from localhost (19.81.93.209.dyn.plus.net. [209.93.81.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35eae5sm73570876f8f.33.2026.06.10.08.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 08:50:06 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Use using instead of typedef In-Reply-To: <87pl1zfymw.fsf@tromey.com> References: <20260609162257.1674992-1-tdevries@suse.de> <87pl1zfymw.fsf@tromey.com> Date: Wed, 10 Jun 2026 16:50:05 +0100 Message-ID: <871peeqtsi.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: p5Fpe2rZGr0PzbQnBP0ktMtqHpNWj2vt2WiKBw56iQA_1781106607 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Tom" == Tom de Vries writes: > > Tom> After commit 1eed06ae51d ("[gdbsupport] Use using instead of typedef in > Tom> next_iterator") I wondered if I could do something similar using sed. > > First of all, thanks for doing this. > > I don't know how anyone else feels but I normally find 'using' simpler > to understand, I suppose because I don't need to try to decode the right > hand side to find the name being defined -- it's right there before the > '='. > > So, I am in favor of this patch. I'm going to approve it but I think > you should wait for a bit before checking it in, in case someone wants > to object. I also think this is a good idea. +1 Thanks, Andrew