From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4cJTHHbWfGqbNiEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 16:24:22 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UEzCcPug; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 62BE61E09B; Wed, 12 Aug 2026 16:24:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B72CD1E09B for ; Wed, 12 Aug 2026 16:24:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D3B784BB24EB for ; Wed, 12 Aug 2026 20:24:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D3B784BB24EB Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UEzCcPug Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 55A8F4BB24EB for ; Wed, 12 Aug 2026 20:23:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55A8F4BB24EB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55A8F4BB24EB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786566236; cv=none; b=DWotNZMJ2/FFLJa2lS7u8Vk/Fylblv9tsdc9qBlKzlS7oNhRPtbu2buCphqKepS2ZgyDcml/RZid5bwLG9tKfCtGMOHew83N0g0sYRtimxr3l6W0Y3pq6bdR4GDlsIDFoGEa9KAkw1WAkz/xRlROAQZeMeEee2eulOPjGDfyB7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786566236; c=relaxed/simple; bh=Odgpx3p4IQchkd2ygD9IOo96sdYWgRq0z04c3q+KwuY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pdYS8vOyDSR3ouY9Yv2BOU07Z8ozHiTEqB+WO3nv15uLbe0ilTOPozM5wYzEetzvWfhTfg1XuFjl3+TXwgZmOZ/bZr34EfrTPXObRtYQlTl3amsLL458U5eXSvTM4GwHDunBIddr1i0AINy3VodNlCAcIVRu1V4R8fb8MjsZIko= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UEzCcPug reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55A8F4BB24EB Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id uDGRwxJlNuFzguFURwO4oD; Wed, 12 Aug 2026 20:23:56 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uFURwfzRg3bwfuFURwPPNu; Wed, 12 Aug 2026 20:23:55 +0000 X-Authority-Analysis: v=2.4 cv=fv/cZE4f c=1 sm=1 tr=0 ts=6a7cd65b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=95WO2MV2feGrhzvqFxIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nNcow4k2aDloWiQ0Zm/QdKRVCutn+G4p6u5GhvFDEeE=; b=UEzCcPugLCOKpAbo+i88Fw12bC 99s0vH0uJooTH23A/EEkV+0Yyelv4GZ8mdN3cJ638C3FuO4IjdOLq94LnxLGFu97lzmRHYX3tz2e3 Ty4rfa+KbDM/ToRUGZxv86zCT; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:53676 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wuFUQ-00000003oCP-3Apb; Wed, 12 Aug 2026 14:23:54 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb/python] Handle error in gdbpy_initialize_gdb_readline In-Reply-To: <20260807223516.3636935-1-tdevries@suse.de> (Tom de Vries's message of "Sat, 8 Aug 2026 00:35:16 +0200") References: <20260807223516.3636935-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 12 Aug 2026 14:23:53 -0600 Message-ID: <871pc3w0iu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wuFUQ-00000003oCP-3Apb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:53676 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJdO2R3sg46akGp5cGfsWkJgHJDyXIDsN8/e0GODWEJik7zO7lXgIG6KthS1RAIHmRHGIJg7b8ktNWRtuBoTAPbRXoKavLP1+61RD4fQtvGk8skZJDzg JBwaEyR0H+d9a4ZQQdvJz+Kf++GzB5MG7ek9S3q+i6Jnh4LsK5uPaPfShOBhx1mgrjvhY/+hI/jykhfF+vpj2G8iRQuO8OP7YRw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> if (eval_python_command (code, Py_file_input) == 0) Tom> PyOS_ReadlineFunctionPointer = gdbpy_readline_wrapper; Tom> + else Tom> + { Tom> + if (PyErr_Occurred ()) Tom> + gdbpy_print_stack (); I don't think the check of PyErr_Occurred is needed, as that's part of the eval_python_command contract. Ok with that removed. Approved-By: Tom Tromey Tom