From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EWE1O6ghtWotzzwAWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 09:12:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TpNn/U+M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE61B1E06B; Thu, 24 Sep 2026 09:12:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 974111E01F for ; Thu, 24 Sep 2026 09:12:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED6974BB5889 for ; Thu, 24 Sep 2026 13:12:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED6974BB5889 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TpNn/U+M Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 382034BB3BDF for ; Thu, 24 Sep 2026 13:11:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 382034BB3BDF Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 382034BB3BDF Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790255473; cv=none; b=t2iTvpu1kYshVzBvWkU0iTpTNA9TcxMComs7e/6Chin8Om5GRYmplKDc7QbSIsaoIOSQBYbBZLI3bCQuOcdHw58oNFL4C7PKCKJ0ecp9axf7iP2wVpxiZpq0DYxXIztXi0cC0/zdP/mp0DPoaFp5IlhLdHawefwTJPu0VM2zKhU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790255473; c=relaxed/simple; bh=e5l60mbjVI39fdIRE5viVLK54JvYBki8VkuMwJH/Vrk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ambZyfyhmy6VEhWcSt/xz1KRZ0WBpo1JlGgCGjWWVuGboEjezQFSjMvn+lZMcUq1+93bAkEE35RMwlx0AtqLspMAecZES39+aqmzZWBRz5u0GDLAj+s6oiWtc0hXmWVX7SCZhLqXH658/yZ6LIkkh8y/H1Due/Ie+bo0OKWf+sc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TpNn/U+M DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 382034BB3BDF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790255472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kqypmO+iguwMIiyO2PclvBXb6AokyKetEDl7w4CQFis=; b=TpNn/U+MFnM3NipPn198IxN5rVqwwTnA3vYRKLcbAh+q5/YFl4q7QA79jfQe/BgV9Bd4yJ Na+sADX73cmM3zNf9VdRX7mpm5pbCK31Byaaxefrp1Ehw5aXGRXKxlp+B3+xAgubvWcuqD 6+Vb0O4wo75fkzIUKppzxoPFZxEUf9c= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-XnfQC8-mMYm9pvDRebxSPw-1; Thu, 24 Sep 2026 09:11:11 -0400 X-MC-Unique: XnfQC8-mMYm9pvDRebxSPw-1 X-Mimecast-MFC-AGG-ID: XnfQC8-mMYm9pvDRebxSPw_1790255470 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-490a767c7dcso15454795e9.2 for ; Thu, 24 Sep 2026 06:11:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790255470; x=1790860270; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kqypmO+iguwMIiyO2PclvBXb6AokyKetEDl7w4CQFis=; b=WICEKAtOTz44w21pRxLQwlSjFHc7R8LSlecYvCdxCIFD50kUcbHFmLxznJCMLnC8Ef Ik0ezjxgk0M9liIcv08Y1kfxFk/OeuSfuBpy7n2n2z/E6O7VC+iu28jxWB4smnjzHMuS gMC7QXoSlC7qrqze+R6UIj+qKHJe16v2mNVpzDPqEwI7xiQH0um0DaopjRSiTcSRC5Tc JpZ7WmYtBIfVXVhQRNAbKNdqDx2QDnejwByrRZJcUOI3HQpEc/nnh/J8HGESzjxGG7be 6u8n+CyiYB2GuTE5LuzX1XoTCceLM5QDkQ4TEj1kbo2ASb/uAPxE8RaaLyodt6/QsImH f/rw== X-Forwarded-Encrypted: i=1; AKwUvBzGGb2Rqn6KLDnD8ZzWCmKyZTtea/hmn5oQ8wZrKxrZU11dP2lVjqc0HApm9frcF9LEHnx2RFMzCYjIWQ==@sourceware.org X-Gm-Message-State: AFuF++n+bbxrG+YYoNelb545PFwClYMvkLsa5apmPOp/Z+NMD4qbU1mS 45s5eAE2Up5MUMhUTYIfgVbGtfc2i/qO9NzkVILJj/hC1jJ4ZxkMLF3biy1fm6YtWeXgUC1dzXi n1NcIC+ThEHDVd7YxDPODZmzCHkq/c48JMmkPCA+7cqUsIGo9F+YhDVTGII8R3gs= X-Gm-Gg: AYBFou0IkPVvOIsNNAPjcJ4zx2p8iGAAE2dQDOesjun34dMhXVNA7gV1itgwoCeCXBX riR4XqVzweIJ6nOmgF4rmsJ5ge448VFMEO/7zxTx1jf43Psrq8y8i5lJ6Koo1TZbtBMB/dL236M e3UwKv0yGPKRPmEIxuKaUdPewddfiH0e0rL0Sg9J58Hsvu3IELVbTNBi79kVf3TY+emEz5kMY24 NAfmujub9tmLXFJR6tDiz7WfscXQ35fy1eURvk3X20s+7/DCY/Fvjq6vv4QNYBKiAjFOWKdAsMR clK5Pf5jvktL6hakFwqc/zJjH+4i5IpLdg/mwHFRW6X3FpvxAzZS4ApEZF/unqoAdmTK X-Received: by 2002:a05:600c:4fc7:b0:49f:cbf1:e76d with SMTP id 5b1f17b1804b1-49fe668568amr39214605e9.0.1790255469873; Thu, 24 Sep 2026 06:11:09 -0700 (PDT) X-Received: by 2002:a05:600c:4fc7:b0:49f:cbf1:e76d with SMTP id 5b1f17b1804b1-49fe668568amr39214105e9.0.1790255469420; Thu, 24 Sep 2026 06:11:09 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe5dfa6a7sm105073325e9.12.2026.09.24.06.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 06:11:08 -0700 (PDT) From: Andrew Burgess To: "Joos, Christina" , "gdb-patches@sourceware.org" Cc: "Rohr, Stephan" Subject: RE: [PATCH v2 1/1] gdb: Enable OS generated corefiles on systems with Intel AMX support. In-Reply-To: References: <20260911163001.3365986-1-christina.joos@intel.com> <87y0cxa21o.fsf@redhat.com> <87v77yapj3.fsf@redhat.com> Date: Thu, 24 Sep 2026 14:11:07 +0100 Message-ID: <871pai3ic4.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9Oo15lhLSkwL2gNVRsVXxwGxZV6Uu6ODBkokEcBJar4_1790255470 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Joos, Christina" writes: >> -----Original Message----- >> From: Andrew Burgess >> Sent: Montag, 21. September 2026 12:05 >> To: Joos, Christina ; gdb-patches@sourceware.org >> Cc: Rohr, Stephan >> Subject: RE: [PATCH v2 1/1] gdb: Enable OS generated corefiles on systems >> with Intel AMX support. >> >> "Joos, Christina" writes: >> >> >> -----Original Message----- >> >> From: Andrew Burgess >> >> Sent: Samstag, 19. September 2026 13:55 >> >> To: Joos, Christina ; >> >> gdb-patches@sourceware.org >> >> Cc: Rohr, Stephan >> >> Subject: Re: [PATCH v2 1/1] gdb: Enable OS generated corefiles on >> >> systems with Intel AMX support. >> >> >> >> Christina Joos writes: >> >> >> >> > This patch addresses the issue described in PR gdb/34561. On >> >> > systems with Intel AMX support the xsave size is 11008. This xsave >> >> > size is not handled by gdb/i387-tdep.c:i387_guess_xsave_layout and >> >> > is causing problems for corefiles generated by the linux kernel. >> >> > The problem is visible regardless of the AMX enablement state in >> >> > the dumping process, so all corefiles on newer systems with AMX are >> broken. >> > >> > Hi Andrew, >> > >> > Thanks a lot for pushing this patch. >> > >> >> FYI: https://sourceware.org/bugzilla/show_bug.cgi?id=34646 >> >> Could you take a look if you have a chance please. >> > >> > As described in the discussion for v1 of this patch [1], the issue >> > described in the bug 34646, just became visible due to the improved >> > test coverage for core files, which are also part of this patch. >> > They are unrelated to the GDB code changes of this patch, so the issue >> > existed before, too. I added a comment in the bug, so this is hopefully clearer >> now. >> > >> > [1] >> > https://sourceware.org/pipermail/gdb-patches/2026- >> September/230279.htm >> > l >> >> Thanks for the explanation. This makes sense. >> >> Would you be OK if I pushed the patch below to master and gdb-18-branch? >> >> This converts the FAIL to XFAIL and points back at PR gdb/34646. I did >> consider creating a brand new bug, but that seemed a little pointless. >> >> Thanks, >> Andrew >> >> ~~~ >> >> commit 95bb312d0f65229d914adffe143c6e561cb285bf >> Author: Andrew Burgess >> Date: Mon Sep 21 10:12:44 2026 +0100 >> >> gdb/testsuite: add xfail to gdb.arch/i386-pkru.exp test script >> >> Add an xfail to the new gdb.arch/i386-pkru.exp test script, which is >> currently failing due to a preexisting issue. The test script was >> added to master in commit: >> >> commit eec39a2f9250c622d86219cc182c4feaa6b07c50 >> Date: Fri Sep 11 18:30:01 2026 +0200 >> >> gdb: Enable OS generated core files on systems with Intel AMX support >> >> And back-ported to gdb-18-branch in commit: >> >> commit 1d77334943a940a0384f6177cc8ceb9dd3852c17 >> Date: Fri Sep 11 18:30:01 2026 +0200 >> >> gdb: Enable OS generated core files on systems with Intel AMX support >> >> The test triggers the OS to generate a core file. GDB then loads the >> core file and inspects the PKRU register. Currently, this register >> does not contain the expected value. This is an existing issue that >> existed before the above commit(s). > > The issue is not reproducible on every machine. > It might make sense to add a comment about that, but since the issue is not yet > fully understood, it would have to be very vague, for instance: > > "Currently, this register does not contain the expected value on some machines." > > For me, both options would be fine (your version or my version). > >> As it is not good to introduce new FAILs, I'm changing the test to >> report XFAIL if we get anything other than the expected PKRU value. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34646 > > Ah, ok - I wasn't sure what the process is in such cases. > > If someone looks at this GDB ticket, they can read the comments in the bug > and will be aware that this issue is not yet understood and may depend on > the environment rather than GDB. So, this is fine from my side. > >> diff --git a/gdb/testsuite/gdb.arch/i386-pkru.exp >> b/gdb/testsuite/gdb.arch/i386-pkru.exp >> index 07a589cba82..926cc7dbfff 100644 >> --- a/gdb/testsuite/gdb.arch/i386-pkru.exp >> +++ b/gdb/testsuite/gdb.arch/i386-pkru.exp >> @@ -113,14 +113,24 @@ gdb_test_multiple "print /x rd_value" "variable after >> reading pkru" { >> >> # Restart gdb, load the core file generated by gcore or the OS # and check >> reading the pkru register from the core file. >> -proc test_corefile {core_filename} { >> +proc test_corefile { core_filename { allow_xfail false } } { >> clean_restart $::testfile >> >> gdb_test "core $core_filename" "Core was generated by .*" \ >> "load core file" >> >> - gdb_test "info register pkru" ".*pkru.*$::val1.*" \ >> - "read pkru register" >> + gdb_test_multiple "info register pkru" "read pkru register" { >> + -re -wrap ".*pkru.*$::val1.*" { >> + pass $gdb_test_name >> + } >> + -re -wrap ".*pkru.*" { >> + if { $allow_xfail } { >> + xfail "$gdb_test_name (PR gdb/34646)" >> + } else { >> + fail $gdb_test_name >> + } >> + } >> + } >> } >> >> with_test_prefix "OS generated core file" { @@ -133,7 +143,7 @@ >> with_test_prefix "OS generated core file" { >> if { $corefile eq "" } { >> unsupported "unable to generate core file" >> } else { >> - test_corefile $corefile >> + test_corefile $corefile true >> } >> } >> } > > As described above, I only have one suggestion for the commit message. > I will leave this up to you to change. > > Since both commit message versions would work for me: > > Approved-By: Christina Joos > I tweaked the commit message as you suggested and pushed this to master and gdb-18-branch. Thanks, Andrew