From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KS54BCL/2Go+SwcAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 14:06:26 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IzVe+0S/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0803A1E04D; Wed, 21 Oct 2026 14:06:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59B1B1E04D for ; Wed, 21 Oct 2026 14:06:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C8A664BA23E1 for ; Wed, 21 Oct 2026 18:06:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8A664BA23E1 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IzVe+0S/ Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id BEA534BA2E09 for ; Wed, 21 Oct 2026 18:05:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEA534BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEA534BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792605958; cv=none; b=gu8j1hDpurIThbuZr+vMGY2R+CMty2XJfxM172nvHmwZIR90CApXeXQbcxG6HyqU+/HvIhoL/uy3ZLCN5yHpCP1/JWGuv8SsEMMMJ/6Ednx+twjD5hPpLmm4MvINdJ6CvQ1sq/IrAxeCEfVUbkNk4xlRVKycBgWCJy2kXjb1Bo0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792605958; c=relaxed/simple; bh=l0467wJR2zA6K4EYKAvHaI/+NyH52I/SLv7S/YyuZAU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mde6HdNmmr+1RIDIWa8Jk7DUO7UUWQT4eYw9aJGYXuh71UwFw3dooga2HKA809+Gaq9/ChZfwZvGshZlR55n9oueRs2+lV7VfS7oE+gji0bV4MiVwOtvA4Y0Ov/jmQV6u1zqlA1jewb11COfkI/41rFpNcODcZoeq4lX/AAA2dM= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IzVe+0S/ reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEA534BA2E09 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id JZWHxk0BLLvgbJahKx95sj; Wed, 21 Oct 2026 18:05:58 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JahIxABGTFB8dJahIxDo1e; Wed, 21 Oct 2026 18:05:56 +0000 X-Authority-Analysis: v=2.4 cv=HcoUTjE8 c=1 sm=1 tr=0 ts=6ad8ff05 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=9xt2tBMZXqJa8-9hqDoA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u56u1F4Fhpaa4KzQMu8v2gDLvYsBdGr84njmkbwvzrw=; b=IzVe+0S/Hvgvfr1xicbFCaJ8Iy ZKeNRdF+2Z8vj0S1xXNHrhWAw+ZZDr0h34F5D/M4Fg5ZWXtgcef3HaDvTXaZd99qEXDdOs+oNyOEl g9IKzzPAXLWWpoPQqVzifgF/l; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:54420 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJahH-000000000u1-3iDY; Wed, 21 Oct 2026 12:05:55 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 27/27] gdb/testsuite/lib/gdb-dlfcn.h: __WIN32__ => _WIN32 In-Reply-To: <20260723130118.206735-28-pedro@palves.net> (Pedro Alves's message of "Thu, 23 Jul 2026 14:01:18 +0100") References: <20260723130118.206735-1-pedro@palves.net> <20260723130118.206735-28-pedro@palves.net> X-Attribution: Tom Date: Wed, 21 Oct 2026 12:05:54 -0600 Message-ID: <871p9jx725.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJahH-000000000u1-3iDY X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:54420 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOJcOG5uCI603g6hIwME/cQVYzajEDqCA4nsTwB0yHEF8fguobd1MN4OuriKXHq8CkzXOLn0xPYq6ZxC/By2A2xRdLqHyAjpiVPXlfL8vyddLwLVwHaU LqNx7XQZrDcEdH3pfNF8uutkSo66lm+b/tp3BUAcvwdewSbQlajk40bSI/Z3TFvhZNbBY/98BovPU6L2joiV95pOJkQXzZ4vj9U= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> testsuite/lib/gdb-dlfcn.h guards the Windows branch with __WIN32__, Pedro> which is a GCC/MinGW-ism. __WIN32__ is not defined by MSVC nor by Pedro> Clang targeting *-windows-msvc, so when testing with (e.g.) Pedro> --target=x86_64-pc-windows-msvc gdb-dlfcn.h takes the branch Pedro> and we fail to build the testcase that included it. Pedro> Fix this by using _WIN32 instead, which is defined on every (native) Pedro> Windows toolchain (and not by Cygwin). Pedro> There are no other references to __WIN32__ in the testsuite. Seems reasonable to me. Approved-By: Tom Tromey Tom