From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9181 invoked by alias); 4 May 2003 09:37:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9166 invoked from network); 4 May 2003 09:37:40 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 4 May 2003 09:37:40 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h449b6dS001534; Sun, 4 May 2003 11:37:06 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h449b6wa029533; Sun, 4 May 2003 11:37:06 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h449b6Yp029530; Sun, 4 May 2003 11:37:06 +0200 (CEST) To: "Kris Warkentin" Cc: "Gdb-Patches@Sources.Redhat.Com" Subject: Re: [PATCH] (dagnabbit) QNX Neutrino i386 support References: <036c01c30ff8$1c97c3c0$0202040a@catdog> From: Mark Kettenis Date: Sun, 04 May 2003 09:37:00 -0000 In-Reply-To: "Kris Warkentin"'s message of "Thu, 1 May 2003 11:41:20 -0400" Message-ID: <86znm3uk71.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-05/txt/msg00040.txt.bz2 "Kris Warkentin" writes: > Well, I'd love to just be submitting a patch to all the already committed > stuff but since you guys haven't approved my stuff yet, now I have to submit > the whole darn thing again. Serves you right. ;-) > > I've gone and refactored a bunch of stuff again. I simplified the interface > into the backend target stuff since we were doing a lot of work for > registers that we didn't need to. Great! > The main (and cool) thing that I did was to take all the backend functions, > put them into a target vector and create defines for all the functions just > like is done in target.h and a few other places. I think it's much more > elegant this way and it also will make it possible to create a multi-arch > gdb for Neutrino down the road. Thanks, very much. This is much, much better. I'm fairly certain this work will pay off itself in the future. Anyway, I have two further wishes, could you rename the following files: config/tm-qnxnto.h -> config/tm-nto.h config/i386/tm-i386nto.h -> config/i386/tm-nto.h config/i386/i386nto.mt -> config/i386/nto.mt This makes things a bit more consistent with recently added new targets. Of course it requires you to make a few changes to take into account the new names. Please make sure you change the #include "qnxnto.h" in config/i386/tm-nto.h into #include "config/tm-nto.h" otherwise you might encounter problems building GDB. Oh and could you make the entry for configure.tgt in the ChangeLog read: * configure.tgt: Add i[3456]86-*-nto*. With those changes, please go ahead and check this in. Mark