From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15625 invoked by alias); 9 Jul 2015 11:50:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15608 invoked by uid 89); 9 Jul 2015 11:50:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Jul 2015 11:50:27 +0000 Received: by pacgz10 with SMTP id gz10so76147193pac.3 for ; Thu, 09 Jul 2015 04:50:25 -0700 (PDT) X-Received: by 10.70.49.5 with SMTP id q5mr23585986pdn.151.1436442625754; Thu, 09 Jul 2015 04:50:25 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id x3sm5402858pdk.61.2015.07.09.04.50.22 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Jul 2015 04:50:25 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdbserver, aarch64] Set userregs to NULL in regs_info References: <1436440940-11732-1-git-send-email-yao.qi@linaro.org> <559E5A60.9060703@redhat.com> Date: Thu, 09 Jul 2015 11:50:00 -0000 In-Reply-To: <559E5A60.9060703@redhat.com> (Pedro Alves's message of "Thu, 09 Jul 2015 12:26:24 +0100") Message-ID: <86zj35lfd2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00283.txt.bz2 Pedro Alves writes: > Typo in subject: "usrregs". > Fixed it in subject and commit log. > On 07/09/2015 12:22 PM, Yao Qi wrote: >> Hi, >> I happen to read the comments in regs_info below, >>=20 >> struct regs_info >> { >> ... >> /* Info used when accessing registers with PTRACE_PEEKUSER / >> PTRACE_POKEUSER. This can be NULL if all registers are >> transferred with regsets .*/ >> struct usrregs_info *usrregs; >>=20 >> that usrregs can be NULL if all registers are transferred with >> regsets, which is exactly what aarch64-linux does. This patch >> is to set userregs to NULL in regs_info and remove >> aarch64_usrregs_info and aarch64_regmap. >>=20 >> Regression tested on aarch64-linux with GDBserver. >>=20 >> gdb/gdbserver: >>=20 >> 2015-07-09 Yao Qi >>=20 >> * linux-aarch64-low.c (aarch64_regmap): Remove. >> (aarch64_usrregs_info): Remove. >> (regs_info): Set field userregs to NULL. > > OK. Patch is pushed in. --=20 Yao (=E9=BD=90=E5=B0=A7)