Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer.

Antoine Tremblay
2015-10-21T12:04:01Z

> This comment should be expanded. Something like:
>
> /* The software breakpoint's kind. This is target specific.
> Most architectures only use one specific instruction for software
> breakpoints, while others may use more than one. E.g., on ARM, we
> need to set different breakpoint instructions on Thumb, Thumb-2,
> and ARM code. */
> int kind;
>

I will remove the "software" specification since hardware breakpoints
have kinds too encoded in this struct see for example :
arm_linux_hw_point_initialize.

Like so :

/* The breakpoint's kind. This is target specific. Most
architectures only use one specific instruction for breakpoints, while
others may use more than one. E.g., on ARM, we need to set different
breakpoint instructions on Thumb, Thumb-2, and ARM code. */