Re: [PATCH v3 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer.

Yao Qi
2015-11-26T10:30:03Z

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

> gdb/gdbserver/ChangeLog:
> * linux-aarch64-low.c (struct linux_target_ops): Rename
> breakpoint_reinsert_addr to get_next_pcs.

Nit: the change is to the_low_target, not "struct linux_target_ops", so
it should be

* linux-aarch64-low.c (the_low_target): ....

> * linux-arm-low.c (struct linux_target_ops): Likewise.
> * linux-bfin-low.c (struct linux_target_ops): Likewise.
> * linux-cris-low.c (struct linux_target_ops): Likewise.
> * linux-crisv32-low.c (struct linux_target_ops): Likewise.
> * linux-low.c (can_software_single_step): Likewise.
> (install_software_single_step_breakpoints): New function.
> (start_step_over): Use install_software_single_step_breakpoints.
> * linux-low.h: New CORE_ADDR vector.
> (struct linux_target_ops) Rename breakpoint_reinsert_addr to
> get_next_pcs.
> * linux-mips-low.c (struct linux_target_ops): Likewise.
> * linux-nios2-low.c (struct linux_target_ops): Likewise.
> * linux-sparc-low.c (struct linux_target_ops): Likewise.

Patch is good to me.

--
Yao (齐尧)