Re: [PATCH v3 08/10] Support software single step on ARM in GDBServer.

Antoine Tremblay
2015-11-27T15:35:17Z

On 11/27/2015 10:15 AM, Yao Qi wrote:
> On 27/11/15 13:45, Antoine Tremblay wrote:
>>
>> And I don't think it's good to have it in 2 calls, so I will have the
>> same collect_register_unsigned_field...
>
> If so, let us keep collect_register_unsigned field.
>>
>> Thus this refactoring would not simplify the patch and IMHO would create
>> some inconsistency why are we using regcache in some place for no
>> apparent gain while all the rest uses frame.
>
> That is what I want to avoid... for the software single step routines
> in two sides (GDB and GDBserver), I don't want to see that regcache is
> used in one side while frame is used in the other side. regcache should
> be used in both sides.
>
>>
>> In light of this, I plan to keep it as is unless there's an objection ?
>
> Sorry, I don't like the patch as is. I plan to change gdbarch method
> software_single_step to something like this,
>
> F:VEC (CORE_ADDR) *:software_single_step:struct regcache *regcache:regcache
>
> it returns a set of address on which GDB can insert software single step
> breakpoint.
>

Alright as long as it's understood that the fields will stay, I'll do it
like this.

Thanks,
Antoine