From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120665 invoked by alias); 11 Feb 2016 17:36:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120648 invoked by uid 89); 11 Feb 2016 17:36:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1259 X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 17:36:56 +0000 Received: by mail-pf0-f195.google.com with SMTP id e127so2812200pfe.3 for ; Thu, 11 Feb 2016 09:36:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=MO3WnVET03B16aKeoFLohVWGu2uNlOB9HqmhgapOyvw=; b=f08H0MoO3FOm5o0IjTIm3/a+yTWKUTvQtfF+dZcsCmNJm4B4KkkdPPyqx80keFH4/1 o7hQRTUPEaqZtIOfAEQeYGP2F7K7XBcNByTED0uMpF36ISEruw7qi4JYCrJkAKgDzixh g33r39HZ/W8Uw8KgYGvZhogNZAz/Nw/EbxX5AGqrAW76OpPxHmYk9+fquhNs4wkpB80H G8XanuC9oZ/1JT3VPxsXNVUfWVLheClcxVVpj32zztBobV+zSn4KKl6JvGIPVrcUdFSU zOHdxoWB7TTbyCkArydYlwpJLSiCie1N0yxcu0WSioX4v70fs1x4Kol5Gt8fap9IrPMT ghSA== X-Gm-Message-State: AG10YOS5WKuf08PJ4ESpB+8NpyKayO0aPnoE/fzaOGCYYdxChqJ7AXxuEfmctkZXhB5bjA== X-Received: by 10.98.18.8 with SMTP id a8mr68563487pfj.41.1455212215159; Thu, 11 Feb 2016 09:36:55 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id r26sm13717851pfb.21.2016.02.11.09.36.52 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 11 Feb 2016 09:36:54 -0800 (PST) From: Yao Qi To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Save target description in tfile. References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> Date: Thu, 11 Feb 2016 17:36:00 -0000 In-Reply-To: <1454773157-31569-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Sat, 6 Feb 2016 16:39:13 +0100") Message-ID: <86ziv7no7i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00382.txt.bz2 Marcin Ko=C5=9Bcielnicki writes: > 1. target.xml is read from the target. > 2. Includes are processed, resulting in a single in-memory XML file > containing all the data. > 3. The resulting file is stored in tfile header by prefixing every line > with "tdesc ". We may insert a spurious newline at the end of file > with this encoding, but that won't matter for XML. > 4. When tfile is read, the XML is stored in an allocated buffer, and > xfer for TARGET_OBJECT_AVAILABLE_FEATURES is implemented, reading > from it. > 5. target_find_description is called to force reading it. The target description is a global state in trace file, so it doesn't work tracepoints have different target descriptions, for example in multi-inferior case, one is x86 and the other one is x86_64 (and arm vs aarch64 too), and we have tracepoints set in two processes. I know tracepoint doesn't support multi-inferior/multi-process, but we may support that in the future. Since we are changing tracepoint file format, we'd better think about this a little bit. Can we save multiple target descriptions in trace file, and associate the tracepoints to the right target description in trace file? --=20 Yao (=E9=BD=90=E5=B0=A7)