From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53147 invoked by alias); 22 Mar 2016 08:55:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53130 invoked by uid 89); 22 Mar 2016 08:55:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 22 Mar 2016 08:55:57 +0000 Received: by mail-pf0-f195.google.com with SMTP id u190so34641139pfb.2 for ; Tue, 22 Mar 2016 01:55:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=zT77PSkBneL6vc4ezsciWRdJkTHsVfbsnJkmI0Aq258=; b=AEYzPSQMpBY28qMI4taOvu0nfkHxhoyFgjWs3odDQzjv/+wwy/ldhM+gJtduFqC9Uc lMAzadp+njXmbvKwgyvZurXQgX/kFASCrK23hLbRqT+Ge6emk5MBSJNepIKkHB9ttkKd Hh9hCjSne15DyK03eNLEVqGxWMawnaKwRUUR2UhLQ1Hr5E2pkHssLTJPgpcZUxBhx/DP 0jnVZzTizkEYpiiS6tbvFKKnQ2nsjORTpFhF2EOIWp2KhxQTz1UlklUsXBqVau2/sjOA Tu9hk/BQlfmg5fBjN+iXjkT5Urxw72vYAduam3VxBwXX4sSY6AhyelhVSIm5VxpKZENr D+LA== X-Gm-Message-State: AD7BkJJ8L92FRDe1TXZ42TusTs7dhzESqAKINWHnP81UEKZyzJ4yJJqZSR/BXb6HMR1Zdg== X-Received: by 10.98.93.155 with SMTP id n27mr52120056pfj.88.1458636956243; Tue, 22 Mar 2016 01:55:56 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id q85sm46432121pfq.81.2016.03.22.01.55.54 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 22 Mar 2016 01:55:55 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 04/25] Introduce interpreter factories References: <1458573675-15478-1-git-send-email-palves@redhat.com> <1458573675-15478-5-git-send-email-palves@redhat.com> Date: Tue, 22 Mar 2016 08:55:00 -0000 In-Reply-To: <1458573675-15478-5-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 21 Mar 2016 15:20:54 +0000") Message-ID: <86zitqvqlo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00445.txt.bz2 Pedro Alves writes: > +void > +interp_factory_register (const char *name, interp_factory_func func) > +{ > + struct interp_factory *f =3D XNEW (struct interp_factory); > + > + f->name =3D name; > + f->func =3D func; > + > + /* FIXME: assert that no factory for NAME is already registered. */ > + VEC_safe_push (interp_factory_p, interpreter_factories, f); > +} It shouldn't be hard to do the assert here, and get rid of the FIXME. --=20 Yao (=E9=BD=90=E5=B0=A7)