From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WBvzFvMNeWdAwgIAWB0awg (envelope-from ) for ; Sat, 04 Jan 2025 05:31:15 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=MvQhcVn7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5B4981E097; Sat, 4 Jan 2025 05:31:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C45421E05C for ; Sat, 4 Jan 2025 05:31:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 652A23858CDA for ; Sat, 4 Jan 2025 10:31:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 652A23858CDA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=MvQhcVn7 Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 081FF3858C5F for ; Sat, 4 Jan 2025 10:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 081FF3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 081FF3858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735986640; cv=none; b=wTa6BcuIFkBUncVu0FL7fAlWK43o35yMoR1LRv91qz+SnDZrGIKU86WjXepAHuGo1n1MnJh/6k6T+clU6WJl3VEQe6mMBB5o+ieY2JKwFLnAirf/AC97QcGQeVx/6Ie5HDUk/jVivso6Gle0tlfpxIqW5oL0VviljkG+aPmBh94= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735986640; c=relaxed/simple; bh=7uWtTtkbeJe25pYYbpEOjeHRdT/6ZIuFpX6rg9GVWLk=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=StaFiOb1jK3JQdZIptJEOyfpncfvDxeuugGN6sTsK8Kz1TCVzYz1oU3l7yZtzkMH0vzx3I1FamScWpNeoOGfgF+fAsBIcveUKgtNHqs3ZIxbIxLDcdAAvZvBFXJD/Q/9m4vW+lwKe5l1/xKz0noTabTt9hiypjWxdlVYRxA99R0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 081FF3858C5F Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU1QV-0007ys-8Y; Sat, 04 Jan 2025 05:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2l15gvK55HmvwQwZDbtSpXW9TuRxnTu6E5rYj3jVxmw=; b=MvQhcVn7i+ZW UCMTIZsIuuHxQlhvnuFvA3JZjlS7YfrH3U9v2ae3wzgVIfxdIRSFMj0gE/Y4wro4yZTmHP4ZSMWPH vjXwMtHhoBh2sWnpIFEawbwwUaKZrq+ht6vxcGCi3mh5y2g4YwdNd+ql6mRGomMobGlgKqcku9KVH h47DfGAG8dYwzpNfhatICz5KYEicMzz+JbUQY7ypoHjfhVimTZuAqErwUVsAycWgA43tOvnwvO7Jg f2IyIF3SXyNdEyysh8ATBNzdTJRoxPi76fnp+ju78+kkzqX4wu9aMezuqdw6Cr9lqYCnJFmMpAzWv oZyzQnmaE0gqYSk6GVkTLw==; Date: Sat, 04 Jan 2025 12:30:34 +0200 Message-Id: <86zfk6eur9.fsf@gnu.org> From: Eli Zaretskii To: Luis Machado Cc: brobecker@adacore.com, gdb-patches@sourceware.org In-Reply-To: <2b81a853-d925-48e7-8e38-d8584f568cde@arm.com> (message from Luis Machado on Fri, 3 Jan 2025 10:05:14 +0000) Subject: Re: GDB 16.0.90 available for testing References: <20241229033130.D7F7F803EA@takamaka.gnat.com> <868qryr6nn.fsf@gnu.org> <864j2hjers.fsf@gnu.org> <2b81a853-d925-48e7-8e38-d8584f568cde@arm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Date: Fri, 3 Jan 2025 10:05:14 +0000 > Cc: gdb-patches@sourceware.org > From: Luis Machado > > On 1/2/25 17:40, Eli Zaretskii wrote: > >> Date: Sun, 29 Dec 2024 14:54:36 +0200 > >> From: Eli Zaretskii > >> Cc: gdb-patches@sourceware.org > >> > >> 2. Compilation error in event-top.c: > >> > >> > >> CXX event-top.o > >> In file included from d:\usr\include\winsock2.h:69, > >> from ./../gdbsupport/gdb_select.h:30, > >> from event-top.c:43: > >> event-top.c: In function 'fd_set* fd_copy(fd_set*, const fd_set*, int)': > >> event-top.c:1279:22: error: invalid conversion from 'const fd_set*' to 'fd_set*' [-fpermissive] > >> 1279 | if (FD_ISSET (i, src)) > >> | ^ > >> | | > >> | const fd_set* > >> d:\usr\include\winsock.h:164:50: note: initializing argument 2 of 'int __FD_ISSET(SOCKET, fd_set*)' > >> 164 | __CRT_ALIAS int __FD_ISSET( SOCKET __fd, fd_set *__set ) > >> | ~~~~~~~~^~~~~ > >> > >> I solved it with an explicit cast, like this: > >> > >> --- gdb/event-top.c~0 2024-12-29 04:50:07.000000000 +0200 > >> +++ gdb/event-top.c 2024-12-29 12:33:48.356713700 +0200 > >> @@ -1276,7 +1276,7 @@ fd_copy (fd_set *dst, const fd_set *src, > >> { > >> FD_ZERO (dst); > >> for (int i = 0; i < n; ++i) > >> - if (FD_ISSET (i, src)) > >> + if (FD_ISSET (i, (fd_set *)src)) > >> FD_SET (i, dst); > >> > >> return dst; > >> > >> But I don't know if this will produce problems for other > >> implementations of FD_ISSET. > > > > No one responded to this part. Is it okay to fix this, or would > > someone please try this first on other platforms? > > > > I gave this a try on aarch64-linux and it builds fine. I see no changes to the > testsuite. > > >> 4. Running "maint selftest" finds one failure: > >> > >> Running selftest help_doc_invariants. > >> help doc broken invariant: command 'signal-event' help doc has over-long line > >> Self test failed: self-test failed at unittests/command-def-selftests.c:121 > >> > >> I fixed that with the following trivial change: > >> > >> --- gdb/windows-nat.c~0 2024-12-29 04:50:07.000000000 +0200 > >> +++ gdb/windows-nat.c 2024-12-29 12:54:32.346946000 +0200 > >> @@ -3114,9 +3114,9 @@ _initialize_windows_nat () > >> > >> add_com ("signal-event", class_run, signal_event_command, _("\ > >> Signal a crashed process with event ID, to allow its debugging.\n\ > >> -This command is needed in support of setting up GDB as JIT debugger on \ > >> -MS-Windows. The command should be invoked from the GDB command line using \ > >> -the '-ex' command-line option. The ID of the event that blocks the \ > >> +This command is needed in support of setting up GDB as JIT debugger on\n\ > >> +MS-Windows. The command should be invoked from the GDB command line using\n\ > >> +the '-ex' command-line option. The ID of the event that blocks the\n\ > >> crashed process will be supplied by the Windows JIT debugging mechanism.")); > >> > >> #ifdef __CYGWIN__ > > > > And what about this one? okay to commit? > > This looks OK to me, as it is a simple formatting fix for the text. Feel free to > push to master and the 16 branch. > > Approved-By: Luis Machado Thanks, I've now installed both changes on the master branch and then cherry-picked them to gdb-16-branch.