Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: viric@viric.name, gdb-patches@sourceware.org
Subject: Re: [PATCH] Document that index-cache requires build ID
Date: Fri, 18 Apr 2025 08:34:08 +0300	[thread overview]
Message-ID: <86zfgeav8v.fsf@gnu.org> (raw)
In-Reply-To: <c7db6e9d-f1e5-4be8-afac-af6a3cf79a84@redhat.com> (message from Guinevere Larsen on Thu, 17 Apr 2025 14:06:31 -0300)

> Date: Thu, 17 Apr 2025 14:06:31 -0300
> Cc: "Eli Zaretskii (eliz@gnu.org)" <eliz@gnu.org>
> From: Guinevere Larsen <guinevere@redhat.com>
> 
>  From 4dfcd1888e3fc3c5707e3f697268d820679a1c7b Mon Sep 17 00:00:00 2001
>  From: =?UTF-8?q?Llu=C3=ADs=20Batlle=20i=20Rossell?= <viric@viric.name>
>  Date: Sun, 6 Apr 2025 13:11:06 +0200
>  Subject: [PATCH] Document that index-cache requires build ID
> 
>  ---
>   gdb/doc/gdb.texinfo | 2 ++
>   gdb/dwarf2/read.c   | 4 ++++
>   2 files changed, 6 insertions(+)
> 
>  diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>  index e034ac53295..37b65ab72ac 100644
>  --- a/gdb/doc/gdb.texinfo
>  +++ b/gdb/doc/gdb.texinfo
>  @@ -22934,6 +22934,8 @@ Indices only work when using DWARF debugging information, not stabs.
>   It is possible for @value{GDBN} to automatically save a copy of this index in a
>   cache on disk and retrieve it from there when loading the same binary in the
>   future.  This feature can be turned on with @kbd{set index-cache enabled on}.
>  +Note that the cache will use the ELF build ID to identify the cached indices,
>  +so files without Build ID will not have their index cached.
>   The following commands can be used to tweak the behavior of the index cache.
> 
> Since there are documentation changes, we need Eli Zaretskii to approve this change. I've CC'd him in this
> email.

Sorry for missing the original submission.

The patch for gdb.texinfo is okay, but please use "build ID", not
"Build ID", for the second instance, to be consistent about the
letter-case.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2025-04-18  5:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-06 11:15 Lluís Batlle i Rossell
2025-04-17 17:06 ` Guinevere Larsen
2025-04-18  5:34   ` Eli Zaretskii [this message]
2026-02-21 17:15     ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zfgeav8v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=viric@viric.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox