From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GBfCEyuOd2iqYDYAWB0awg (envelope-from ) for ; Wed, 16 Jul 2025 07:34:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=QZTO7pvs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4BE991E11C; Wed, 16 Jul 2025 07:34:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 209FB1E089 for ; Wed, 16 Jul 2025 07:34:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D0C7385801B for ; Wed, 16 Jul 2025 11:34:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D0C7385801B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=QZTO7pvs Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 001E43857BA5 for ; Wed, 16 Jul 2025 11:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 001E43857BA5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 001E43857BA5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752665462; cv=none; b=paIpeo1v5IhXNjTqgolZ9kAycyTHPyfI6YDx2End/iXOWyxsqlNY5fs1wKB7AdAEnBmn9Rvatfm4S7AoqXQF2gONS5lQC0OPY+477aAl/UfLuKiP8tzQdMbrP8mJd9l6OKvkp+U8hWufxHRXI4PfiISZGoZIcAibe5wPXushpuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752665462; c=relaxed/simple; bh=IUBnvDJaw4EMCUckWCPRFEvl9IxpSo7LtdPygqZKcRs=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=okygSdZ8gOg/VcRh6XZgurqG8dRuyQ9bhPWs7gabA8q91JCcAT343yMnOWE0f4zWHIOKXDK+/2QGPc/M/ydF2Lg3lv/9QETYJvJlVkrUaxTKrDHVd8UipZrA22xCdUdQvZza4+BBj1u/fecstwd8lC8fg5yAzVjREEAZHDQQNao= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 001E43857BA5 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uc0Ll-0003Mz-DO; Wed, 16 Jul 2025 07:31:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=afr1xw8glF1YhtaFrybcI4pf40cgbohex4oDT8rXw34=; b=QZTO7pvsfeTF mOgKvHVLW1mI8ZWlLDWAqEUfgLFkXt9kbF43BVgfgPu7tTUguh4CEX6I+TVdAvY6doHiYA74VBPc3 iP5YnVohqhfkNI2Iphyq+UMhuiMKS+G84kV0jw/SxJQv4gMxuv9osMB4VktTuBzOzNgNOcf+YzDEk NyWg3iIKUXoTCxC7kQIUdAe80PmuxNfGlup+H7uQONNGSsKYngaSFTzbrCoLm3d3txCZADMnM0dT/ g1lhatZ3exEuTE3gdM9NXpULGudRv3lQidZnjY2cR0ibrzIEhpykJKc8kR2b44rgIr56HoX/PjWUH HEeoiKq5Yh6O2GqDWxZZXQ==; Date: Wed, 16 Jul 2025 14:30:07 +0300 Message-Id: <86zfd4ida8.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20250715193747.30735-1-tdevries@suse.de> (message from Tom de Vries on Tue, 15 Jul 2025 21:37:47 +0200) Subject: Re: [PATCH] [gdb/cli] Improve the pagination prompt References: <20250715193747.30735-1-tdevries@suse.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom de Vries > Date: Tue, 15 Jul 2025 21:37:47 +0200 > > Currently the pagination prompt is: > ... > --Type for more, q to quit, c to continue without paging-- > ... > > PR cli/33149 points out an inconsistency. > > While typing works as advertised, pressing q or c doesn't have any > other effect than echoing the character to screen. An additional is > needed. > > This is a regression since commit eb6af80922a ("Add "continue" response to > pager"), which changed: > ... > ---Type to continue, or q to quit--- > ... > into: > ... > --Type for more, q to quit, c to continue without paging-- > ... > > Fix this by using the slightly longer (69 instead of 64 chars): > ... > --Type (more), q (quit), or c (continue, no paging)-- > ... Thanks, but why is described as "more" whereas c as "continue, no paging" instead of "more, no paging"? > > Also update the documentation to clarify the same issue. > > In the testsuite, update the pagination_prompt variable and use it in more > test-cases. > > In some test-cases, matching the pagination prompt was split up to address a > matching race but that's no longer necessary, thanks to commit c3f814a1433 > ("Fix paginate-*.exp races"). > > Tested on aarch64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33149 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -27921,9 +27921,9 @@ Certain commands to @value{GDBN} may produce large amounts of > information output to the screen. To help you read all of it, > @value{GDBN} pauses and asks you for input at the end of each page of > output. Type @key{RET} when you want to see one more page of output, > -@kbd{q} to discard the remaining output, or @kbd{c} to continue > -without paging for the rest of the current command. Also, the screen > -width setting determines when to wrap lines of output. Depending on > +@kbd{q} @key{RET} to discard the remaining output, or @kbd{c} @key{RET} to The markup here is incorrect, it should be @kbd{q @key{RET}}, i.e. the entire user input should be inside @kbd. Please also correct "Type @key{RET}" to say "Type @kbd{@key{RET}}" instead, for the same reason. The principles are: @key{FOO} just describes the key labeled "FOO"; anything the user should type should be in @kbd. Also, no NEWS entry for this? Reviewed-By: Eli Zaretskii