From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ig6FOk4QA2rMdTMAWB0awg (envelope-from ) for ; Tue, 12 May 2026 07:34:38 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=iFXiSRYI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DBD211E093; Tue, 12 May 2026 07:34:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1ACD11E093 for ; Tue, 12 May 2026 07:34:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CE894BABF3B for ; Tue, 12 May 2026 11:34:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CE894BABF3B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=iFXiSRYI Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 4821E4BAD17E for ; Tue, 12 May 2026 11:33:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4821E4BAD17E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4821E4BAD17E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778585638; cv=none; b=Dzf/nNBtHXSyB95bFSIadVJnvtMFwM5B1FYyCSGQAzHqAKiQEjROpHomDS7mXjyzBclkpnxIlJ+fSEbCFd5RK31uiORHt64aJnubbBtMX8Aiv3BeFm2VCYFZxwvFhfFa9+iXF7JnIfijvCekW+flIDVMroRk4rvKqEGsG5BKKYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778585638; c=relaxed/simple; bh=5Zzdu6tCjOy7ZREntLFiCQF+M8Hvr2E9cggV4PjsXvg=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=D6+JFOXrNh29qg9QE4+ZR147pZTuzU/R0JH+nFPdCM2+/jUSVTc8yxw45MsiSoE7RUSRHZai9T9O+3mLWHhUz5QYlfvkRCdjlsdvdm3I26HmWw8grIOl+K5dALfMLt8GMKfqTnohgEzD74MVeiK9V1fl2A+vCS3W+COSE40dx3o= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=iFXiSRYI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4821E4BAD17E Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wMlN7-0007Ip-0h; Tue, 12 May 2026 07:33:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7Z4D9pVRrQczU95s0hXwxSkkQHKKBXFdYBut3BVOObs=; b=iFXiSRYI46wN 0f0ycPcpWzk6A3NRsOMeoWUCbvkuWfmY/NC+jqXBgMlqOUlE5dcVA8PMDvd1KXPhTPPRVomc4r2fj WTrnSCu0RjT7ZeitlEql2IdtxioPX3lrxnd5QjAdA3uDq0VyOKSZAvfG0aGwq13uIKhWj+0Lfer2X w5bjMiXG2oLa6Bpjmq6Xriyo3enShxLStkbDfApMKHGUh+75H6btAWH5nSEGDYaTFTi1fGRrN3Rvo asZXCj5cNwguoy7e1mRpWvoFsX2A6QrkRDoT/5jhNoak8f04rvKDHFFyOrwt7QY/scDsoDFuOvEZ3 efj/Vku6NQNtODJGn3+MYw==; Date: Tue, 12 May 2026 14:33:53 +0300 Message-Id: <86zf24zwta.fsf@gnu.org> From: Eli Zaretskii To: Zander Work Cc: gdb-patches@sourceware.org, guinevere@redhat.com, tom@tromey.com In-Reply-To: <20260512013237.646630-2-zdw@google.com> (message from Zander Work on Mon, 11 May 2026 18:32:38 -0700) Subject: Re: [PATCH v2] Use "output-radix" setting to format function offsets References: <350b3a8d-3174-4703-b532-4ba49fe5ea05@redhat.com> <20260512013237.646630-2-zdw@google.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Zander Work > Cc: guinevere@redhat.com, > tom@tromey.com, > Zander Work > Date: Mon, 11 May 2026 18:32:38 -0700 > > Thank you for the review Guinevere! I fixed the formatting issue you > flagged, and added your review tag. > > Global maintainers: I haven't done a FSF copyright assignment, please > let me know how I should do that. If you are an employee of Google, I think they have a blanket assignment covering all of their employees? Tom, am I right? Failing that, we can send you the form to fill and the instructions to go with it, so you could start your assignment paperwork rolling. > This is a patch for a discussion [1] I had previously where it was > determined that it was a bug for GDB to not use the "output-radix" > setting for function offsets. > > This patch includes updates to the radix.exp tests, and I verified that > there were no new breakages added when running the full gdb testsuite > with this patch. > > I didn't make any changes to NEWS or a /gdb/ Changelog entry for this, > if I should please let me know. Yes, this needs an entry in NEWS. I think the descriptions of output-radix and of the "disassemble" command in the GDB manual should also be updated to reflect the change. Thanks.