From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37339 invoked by alias); 21 Apr 2015 11:40:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37325 invoked by uid 89); 21 Apr 2015 11:40:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f173.google.com Received: from mail-pd0-f173.google.com (HELO mail-pd0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 21 Apr 2015 11:40:39 +0000 Received: by pdbqa5 with SMTP id qa5so239192123pdb.1 for ; Tue, 21 Apr 2015 04:40:37 -0700 (PDT) X-Received: by 10.68.241.9 with SMTP id we9mr36190898pbc.59.1429616437636; Tue, 21 Apr 2015 04:40:37 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id x10sm1864817pas.5.2015.04.21.04.40.35 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 21 Apr 2015 04:40:36 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 12/17] Fix interrupt-noterm.exp on targets always in non-stop References: <1429267521-21047-1-git-send-email-palves@redhat.com> <1429267521-21047-13-git-send-email-palves@redhat.com> Date: Tue, 21 Apr 2015 11:40:00 -0000 In-Reply-To: <1429267521-21047-13-git-send-email-palves@redhat.com> (Pedro Alves's message of "Fri, 17 Apr 2015 11:45:16 +0100") Message-ID: <86y4llyajb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00765.txt.bz2 Pedro Alves writes: > Most of the patch is an across-the-board rename of to_stop hook > implementations to to_interrupt. The only targets where something except on gnu-nat.c, > more than a rename is being done are linux-nat.c and remote.c, which > are the only targets that support async, and thus are the only ones > the core side calls target_stop on. > > gdb/ChangeLog: > 2015-04-17 Pedro Alves > > * darwin-nat.c (darwin_stop): Rename to ... > (darwin_interrupt): ... this. > (_initialize_darwin_inferior): Adjust. > * gnu-nat.c (gnu_stop): Delete. > (gnu_thread_alive): Don't install gnu_stop. ^^^^^^^^^^^^^^^^^ gnu_target > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index d830773..4753634 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -2271,12 +2271,6 @@ gnu_terminal_init (struct target_ops *self) > child_terminal_init_with_pgrp (gnu_current_inf->pid); > } >=20=20 > -static void > -gnu_stop (struct target_ops *self, ptid_t ptid) > -{ > - error (_("to_stop target function not implemented")); > -} > - > static int > gnu_thread_alive (struct target_ops *ops, ptid_t ptid) > { > @@ -2686,7 +2680,6 @@ gnu_target (void) > t->to_mourn_inferior =3D gnu_mourn_inferior; > t->to_thread_alive =3D gnu_thread_alive; > t->to_pid_to_str =3D gnu_pid_to_str; > - t->to_stop =3D gnu_stop; >=20=20 > return t; > } Any reason you don't install to_interrupt for gnu-nat? --=20 Yao (=E9=BD=90=E5=B0=A7)