From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57765 invoked by alias); 27 Aug 2015 13:26:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57713 invoked by uid 89); 27 Aug 2015 13:26:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 27 Aug 2015 13:26:13 +0000 Received: by pacti10 with SMTP id ti10so26468729pac.0 for ; Thu, 27 Aug 2015 06:26:11 -0700 (PDT) X-Received: by 10.68.69.34 with SMTP id b2mr6476914pbu.119.1440681971745; Thu, 27 Aug 2015 06:26:11 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id u10sm2492273pdp.85.2015.08.27.06.26.08 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Thu, 27 Aug 2015 06:26:10 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] Merge async and sync code paths some more References: <1439398917-22761-1-git-send-email-palves@redhat.com> <1439398917-22761-2-git-send-email-palves@redhat.com> <86wpws3ma3.fsf@gmail.com> <55D48E6B.7030903@redhat.com> Date: Thu, 27 Aug 2015 13:26:00 -0000 In-Reply-To: <55D48E6B.7030903@redhat.com> (Pedro Alves's message of "Wed, 19 Aug 2015 15:10:51 +0100") Message-ID: <86y4gwzwuu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00782.txt.bz2 Pedro Alves writes: > Nope, not yet at least, though centralizing sigint handling in the event > loop would probably be a good goal. > > It's actually still handled by set_sigint_trap -> inflow.c:pass_signal. > The difference is that after this patch, linux_nat_terminal_inferior > also calls set_sigint_trap itself in sync mode, so these call in > linux_nat_wait_1 are no longer necessary. They actually become harmful, > because set_sigint_trap/clear_sigint_trap are not idempotent. > A sequence of calls like set_sigint_trap -> set_sigint_trap -> clear_sigi= nt_trap > ends up with the wrong SIGINT handler set... OK, I see. > > Thanks, here's the patch that I plan to push, unless you have > further comments. I don't have comments, please go ahead. --=20 Yao (=E9=BD=90=E5=B0=A7)