From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23812 invoked by alias); 28 Sep 2015 10:33:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23205 invoked by uid 89); 28 Sep 2015 10:33:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f46.google.com Received: from mail-pa0-f46.google.com (HELO mail-pa0-f46.google.com) (209.85.220.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 28 Sep 2015 10:33:31 +0000 Received: by pacex6 with SMTP id ex6so171250325pac.0 for ; Mon, 28 Sep 2015 03:33:29 -0700 (PDT) X-Received: by 10.68.227.227 with SMTP id sd3mr26306176pbc.116.1443436409776; Mon, 28 Sep 2015 03:33:29 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id gv1sm18539350pbc.38.2015.09.28.03.33.28 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 28 Sep 2015 03:33:29 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH 4/5] Handle breakpoint kinds for software breakpoints in GDBServer. References: <1442577749-6650-1-git-send-email-antoine.tremblay@ericsson.com> <1442577749-6650-5-git-send-email-antoine.tremblay@ericsson.com> Date: Mon, 28 Sep 2015 10:33:00 -0000 In-Reply-To: <1442577749-6650-5-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Fri, 18 Sep 2015 08:02:28 -0400") Message-ID: <86y4fq7s0d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00600.txt.bz2 Antoine Tremblay writes: > diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h > index 603819e..bf4c3c7 100644 > --- a/gdb/gdbserver/target.h > +++ b/gdb/gdbserver/target.h > @@ -446,6 +446,10 @@ struct target_ops > can be NULL, the default breakpoint for the target should be return= ed in > this case. */ > const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *len= ptr); > + > + /* Returns a breakpoint from a length, the length can have target spec= ific > + meaning like the z0 kind parameter. */ > + const unsigned char *(*breakpoint_from_length) (int *len); > }; If you agree on my comments to patch 2/5, we can rename this hook to breakpoint_from_z0_kind. --=20 Yao (=E9=BD=90=E5=B0=A7)