From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114264 invoked by alias); 11 Dec 2015 14:45:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114251 invoked by uid 89); 11 Dec 2015 14:45:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pf0-f179.google.com Received: from mail-pf0-f179.google.com (HELO mail-pf0-f179.google.com) (209.85.192.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 11 Dec 2015 14:45:41 +0000 Received: by pfnn128 with SMTP id n128so67210922pfn.0 for ; Fri, 11 Dec 2015 06:45:39 -0800 (PST) X-Received: by 10.98.65.206 with SMTP id g75mr15685116pfd.105.1449845139093; Fri, 11 Dec 2015 06:45:39 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id pb9sm26110046pac.38.2015.12.11.06.45.36 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 11 Dec 2015 06:45:38 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Yao Qi , Subject: Re: [PATCH v7.1] Support software single step on ARM in GDBServer. References: <1449583641-18156-7-git-send-email-antoine.tremblay@ericsson.com> <1449691701-11845-1-git-send-email-antoine.tremblay@ericsson.com> <867fklqflh.fsf@gmail.com> <566AD173.2060509@ericsson.com> <566AD26E.5060902@ericsson.com> Date: Fri, 11 Dec 2015 14:45:00 -0000 In-Reply-To: <566AD26E.5060902@ericsson.com> (Antoine Tremblay's message of "Fri, 11 Dec 2015 08:41:02 -0500") Message-ID: <86y4d1oxgy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00234.txt.bz2 Antoine Tremblay writes: > Ooops no this is correct after all > > arm_gdbserver_get_next_pcs (CORE_ADDR pc, struct regcache *regcache) > > in linux-arm-low is using &thumb2_breakpoint. > > I think it's better to have them all the the same area also, so it's > ok to have them there. Then, I'd like to move thumb2_breakpoint out only, but I can bear with your change. Except some format issues I pointed out in another mail, this patch looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)